fix: return single bucket when all scores are identical in _compute_buckets#16
Open
sl628 wants to merge 1 commit into
Open
fix: return single bucket when all scores are identical in _compute_buckets#16sl628 wants to merge 1 commit into
sl628 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
When all scores are identical,
np.percentile()collapses all boundaries to the same value, causing buckets p0–p75 to returncount=0/reduced_centroid=nullwhile all records pile into the final bucket.The fix runs PCA first, then checks if all scores are unique before computing percentiles. If all scores are identical, it returns a single
p0-p100bucket with the correct count and centroid.