Repository navigation
mono - chore: sync defense-in-depth files from agentic - #152
Conversation
Append the current agentic sections to AGENTS.md. The sections match upstream commit e32418b. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates AGENTS.md to include guidelines on Simplified Technical English (STE), Safe Chain shims, test audits, and pull request workflows. The review feedback suggests improvements to align the newly added text with ASD-STE100 STE standards (such as replacing 'free of charge' with 'free' and 'approximately' with 'about') and to correct a grammatical phrasing ('decide from who' to 'decide based on who').
| Write in ASD-STE100 Simplified Technical English (STE). Get the current issue of the specification | ||
| free of charge from <https://www.asd-ste100.org>. STE applies to all text that you write for this |
There was a problem hiding this comment.
The phrase 'free of charge' is an idiom, which is not permitted in ASD-STE100 Simplified Technical English (STE). It is better to use 'free' or 'at no cost'.
| Write in ASD-STE100 Simplified Technical English (STE). Get the current issue of the specification | |
| free of charge from <https://www.asd-ste100.org>. STE applies to all text that you write for this | |
| Write in ASD-STE100 Simplified Technical English (STE). Get the current issue of the specification\nfree from <https://www.asd-ste100.org>. STE applies to all text that you write for this |
There was a problem hiding this comment.
Keep the upstream words at AGENTS.md:10. This line matches the agentic template at commit e32418b (skills/security/defense-in-depth-nodejs/templates/AGENTS.md). A local word change marks the section as locally edited. The next sync does not replace a locally edited section.
| The task does not stop when you open a pull request. Do these steps before you start a different | ||
| task: | ||
|
|
||
| 1. Wait approximately 20 minutes for automated and human code reviews. |
There was a problem hiding this comment.
In ASD-STE100 Simplified Technical English (STE), the word 'approximately' is not an approved word. The approved word is 'about'.
| 1. Wait approximately 20 minutes for automated and human code reviews. | |
| 1. Wait about 20 minutes for automated and human code reviews. |
There was a problem hiding this comment.
Keep the upstream words at AGENTS.md:74. This line matches the agentic template at commit e32418b (skills/security/defense-in-depth-nodejs/templates/AGENTS.md). A local word change marks the section as locally edited. The next sync does not replace a locally edited section.
| 3. Examine the code for each finding or change request. Decide if it is correct. Do not decide from | ||
| who the reviewer is. |
There was a problem hiding this comment.
The phrase 'decide from who' is grammatically incorrect. It should be 'decide based on who' or 'decide because of who' to be grammatically correct and clear.
| 3. Examine the code for each finding or change request. Decide if it is correct. Do not decide from | |
| who the reviewer is. | |
| 3. Examine the code for each finding or change request. Decide if it is correct. Do not decide based on\n who the reviewer is. |
There was a problem hiding this comment.
Keep the upstream words at AGENTS.md:77. This line matches the agentic template at commit e32418b (skills/security/defense-in-depth-nodejs/templates/AGENTS.md). A local word change marks the section as locally edited. The next sync does not replace a locally edited section.
|
The three comments ask for local edits to the copied sections. I left the text as it is. Each section matches the agentic template at commit e32418b. A local edit marks the section as locally edited, and the next sync does not replace it. I replied on each thread. |
mockhttp.org now returns 500 for this delete call. The test uses a local fetch mock and checks the sent body. Co-authored-by: Jared Wray <me@jaredwray.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 639 639
Branches 146 146
=========================================
Hits 639 639 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Summary
AGENTS.md now has the current agentic policy sections. The sections were absent. They match upstream commit e32418bda485f26930b664065a1b860d64173c79.
CI also failed on
should handle a delete request with string data.mockhttp.orgnow returns 500 for that delete call. The test now uses a local fetch mock.Changes
test/base-service.test.tsso the test does not depend onmockhttp.org.Verification
AGENTS.mdmatches agentic e32418b (skills/security/defense-in-depth-nodejs/templates/AGENTS.md).pnpm exec biome check --error-on-warnings test/base-service.test.tspasses.pnpm exec vitest run test/base-service.test.tspasses (14 tests).should handle a delete request with string data. The live host returns 500 (Code generation from strings disallowed for this context). The test still checks thatdelete()sends the data body and returns status 200 when the server returns 200. No test was deleted.Files
AGENTS.mdmatches upstream commite32418bda485f26930b664065a1b860d64173c79.