Skip to content

Correcting a __hash__ function, has no practical effect due to the unique_together constraints but it is still not correct #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frjo wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Correcting a __hash__ function, has no practical effect due to the unique_together constraints but it is still not correct #4865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hypha/apply/funds/models/assigned_reviewers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ class Meta:
verbose_name_plural = _("assigned reviewers")

def __hash__(self):
return hash(self.pk)
return hash((self.reviewer_id, self.role_id))

def __str__(self):
return f"{self.reviewer}"
Expand Down