New SNTP implementation

.changesets/SNTP-impl.md

@@ -0,0 +1,32 @@
+release: minor
+summary: Rework SNTP module in ST-LIB to use ST-LIB scheduler instead of Lwip one
+
+example usage:
+
+```cpp
+/* ... */
+int main(void) {
+    MainBoard::init();
+
+    led_instance = &MainBoard::instance_of<led>();
+    auto eth_instance = &MainBoard::instance_of<eth>();
+
+    Scheduler::register_task(200'000, []{ led_instance->toggle(); });
+
+    ST_LIB::SNTP::start("192.168.0.9");
+
+    Scheduler::register_task(1'000'000, []{
+        RTCData data = Global_RTC::get_rtc_timestamp();
+        INFO("RTC: %u; %uyr %umon %uday %uh %umin %us",
+            data.counter, data.year, data.month, data.day,
+            data.hour, data.minute, data.second);
+    });
+
+    while (1) {
+        eth_instance->update();
+        Scheduler::update();
+        Diagnostics::Hub::flush();
+    }
+}
+```
+Led is not needed but it is to show the board is doing work.

CMakeLists.txt

@@ -252,7 +252,7 @@ if(CMAKE_CROSSCOMPILING)
       ${CMAKE_CURRENT_LIST_DIR}/STM32CubeH7/Middlewares/Third_Party/LwIP/src/core/ipv4/ip4.c
       ${CMAKE_CURRENT_LIST_DIR}/STM32CubeH7/Middlewares/Third_Party/LwIP/src/core/ipv4/ip4_addr.c
       ${CMAKE_CURRENT_LIST_DIR}/STM32CubeH7/Middlewares/Third_Party/LwIP/src/core/ipv4/ip4_frag.c
-      ${CMAKE_CURRENT_LIST_DIR}/STM32CubeH7/Middlewares/Third_Party/LwIP/src/apps/sntp/sntp.c
+      #${CMAKE_CURRENT_LIST_DIR}/STM32CubeH7/Middlewares/Third_Party/LwIP/src/apps/sntp/sntp.c
       ${CMAKE_CURRENT_LIST_DIR}/STM32CubeH7/Middlewares/Third_Party/LwIP/src/netif/ethernet.c
     )
 

Inc/HALAL/Services/Communication/Ethernet/NewEthernet.hpp

@@ -240,8 +240,6 @@ struct EthernetDomain {
     }
     // Runtime object
     struct Instance {
-        const char* sntp_server{nullptr};
-        bool sntp_started{false};
 
         constexpr Instance() {}
         void update() {
@@ -256,12 +254,6 @@ struct EthernetDomain {
                     netif_set_up(&gnetif);
                 }
             }
-
-            if (!sntp_started && sntp_server != nullptr && sntp_server[0] != '\0' &&
-                netif_is_link_up(&gnetif)) {
-                SNTP::sntp_update(sntp_server);
-                sntp_started = true;
-            }
         }
         bool is_connected() { return netif_is_link_up(&gnetif); }
     };

Inc/HALAL/Services/Communication/SNTP/SNTP.hpp

@@ -3,24 +3,177 @@
  *
  *  Created on: 21 feb. 2023
  *      Author: Ricardo
+ *  Edited on: 22 sep. 2026
+ *      by: Víctor
  */
 
 #pragma once
 
-#include "lwip/apps/sntp.h"
+// #include "lwip/apps/sntp.h"
+#include "lwip/udp.h"
 #include "HALAL/Models/IPV4/IPV4.hpp"
 #include "C++Utilities/CppUtils.hpp"
+#include "HALAL/Services/Time/Scheduler.hpp"
 
-class SNTP {
-public:
-    static constexpr const char* DEFAULT_SERVER_IP = "192.168.0.9";
+#ifndef STLIB_SNTP_PORT
+/* default port is 8123 */
+#define STLIB_SNTP_PORT 8123
+#endif
 
-    static void sntp_update(
+namespace ST_LIB {
+
+struct SNTP {
+    /* config values for SNTP */
+
+    static constexpr uint16_t PORT = STLIB_SNTP_PORT;
+    static constexpr uint8_t MAX_SERVERS = 1;
+    static constexpr uint32_t RETRY_TIMEOUT = 15000;
+    static constexpr uint32_t RECV_TIMEOUT = 15000;
+    static constexpr uint32_t UPDATE_DELAY = 3600000;
+
+    /* to have a maximum amount of time SNTP is on for, we use retry_max and recv_max constants */
+
+    static constexpr uint16_t REQUEST_MAX = 512;
+    static constexpr uint16_t RECV_MAX = 8;
+
+    /* start SNTP, will stop after REQUEST_MAX requests or
+     * RECV_MAX replies from the server
+     */
+    static void start(ip_addr_t address);
+    /* start SNTP, will stop after REQUEST_MAX requests or
+     * RECV_MAX replies from the server
+     */
+    static void start(const char* ip);
+    /* start SNTP, will stop after REQUEST_MAX requests or
+     * RECV_MAX replies from the server
+     */
+    static void start(
         uint8_t address_head,
         uint8_t address_second,
         uint8_t address_third,
         uint8_t address_last
     );
-    static void sntp_update(string ip);
-    static void sntp_update();
-};
+
+    /* manually stop STNP */
+    static void stop(void);
+
+    /* SNTP enum values */
+
+    static constexpr uint8_t OPMODE_POLL = 0;
+    static constexpr uint8_t OPMODE_LISTENONLY = 1;
+
+    /* chosen opmode */
+    static constexpr uint8_t MODE = SNTP::OPMODE_POLL;
+
+    /* SNTP specific values */
+
+    /* kiss-of-death packet */
+    static constexpr uint8_t ERR_KOD = 1;
+
+    static constexpr uint16_t MSG_LEN = 48;
+
+    /* NOTE: We don't care about leap seconds so we'll use no-warning */
+    static constexpr uint8_t LEAP_INDICATOR_NO_WARNING = 0x00 << 6;
+    static constexpr uint8_t LEAP_INDICATOR_LAST_MINUTE_61_SEC = 0x01 << 6;
+    static constexpr uint8_t LEAP_INDICATOR_LAST_MINUTE_59_SEC = 0x02 << 6;
+    static constexpr uint8_t LEAP_INDICATOR_ALARM_CONDITION = 0x03 << 6;
+
+    /* SNTP Version 4 */
+    static constexpr uint8_t VERSION = 4 << 3;
+
+    static constexpr uint8_t MODE_MASK = 0x07;
+    static constexpr uint8_t MODE_CLIENT = 0x03;
+    static constexpr uint8_t MODE_SERVER = 0x04;
+    static constexpr uint8_t MODE_BROADCAST = 0x05;
+
+    static constexpr uint8_t OFFSET_STRATUM = 1;
+    static constexpr uint8_t STRATUM_KOD = 0x00;
+
+    static constexpr uint8_t OFFSET_TRANSMIT_TIME = 40;
+
+    struct Server {
+#if SNTP_SERVER_DNS
+        const char* name;
+#endif /* SNTP_SERVER_DNS */
+        ip_addr_t addr;
+#if SNTP_MONITOR_SERVER_REACHABILITY
+        /** Reachability shift register as described in RFC 5905 */
+        u8_t reachability;
+#endif /* SNTP_MONITOR_SERVER_REACHABILITY */
+    };
+
+    /**
+     * 64-bit NTP timestamp, in network byte order.
+     */
+    struct Time {
+        uint32_t sec;
+        uint32_t frac;
+    };
+
+    struct Timestamps {
+#if SNTP_COMP_ROUNDTRIP || SNTP_CHECK_RESPONSE >= 2
+        SNTP::Time orig;
+        SNTP::Time recv;
+#endif
+        SNTP::Time xmit;
+    };
+
+#pragma pack(push, 1)
+    struct Message {
+        uint8_t li_vn_mode;
+        uint8_t stratum;
+        uint8_t poll;
+        uint8_t precision;
+        uint32_t root_delay;
+        uint32_t root_dispersion;
+        uint32_t reference_identifier;
+        uint32_t reference_timestamp[2];
+        uint32_t originate_timestamp[2];
+        uint32_t receive_timestamp[2];
+        uint32_t transmit_timestamp[2];
+    };
+#pragma pack(pop)
+
+    static inline SNTP::Server servers[SNTP::MAX_SERVERS];
+
+#if SNTP_SUPPORT_MULTIPLE_SERVERS
+    /** The currently used server (initialized to 0) */
+    static inline uint8_t sntp_current_server;
+    static inline void try_next_server(const ip_addr_t* server_addr) {
+#error SNTP multiple servers not supported.
+    }
+#else  /* SNTP_SUPPORT_MULTIPLE_SERVERS */
+    static constexpr uint8_t current_server = 0;
+#endif /* SNTP_SUPPORT_MULTIPLE_SERVERS */
+
+    /** The UDP pcb used by the SNTP client */
+    static inline struct udp_pcb* pcb;
+    static inline uint32_t retry_timeout = SNTP::RETRY_TIMEOUT;
+
+    /* internals */
+
+    static inline uint16_t request_task_id = Scheduler::INVALID_ID;
+    static inline uint16_t try_next_server_task_id = Scheduler::INVALID_ID;
+    static inline uint8_t opmode = SNTP::MODE;
+
+    static inline uint16_t request_count = 0;
+    static inline uint16_t recv_count = 0;
+
+    static void initialize_request(SNTP::Message* req);
+    static void send_request(const ip_addr_t* server_addr);
+    static void retry(void);
+    static void request(void);
+    static void process(const SNTP::Timestamps* timestamps);
+
+    static void
+    recv(void* arg, struct udp_pcb* pcb, struct pbuf* p, const ip_addr_t* addr, u16_t port);
+
+#if !SNTP_SUPPORT_MULTIPLE_SERVERS
+    static constexpr void (*try_next_server)(void) = SNTP::retry;
+#endif
+}; // struct SNTP
+}; // namespace ST_LIB
+
+#if 0
+static constexpr const char* DEFAULT_SERVER_IP = "192.168.0.9";
+#endif