Skip to content

Require completed updates for serving snapshots - #520

Open
mikkel wants to merge 16 commits into
developfrom
refactor/serving-transition-contract
Open

mikkel wants to merge 16 commits into
developfrom
refactor/serving-transition-contract

Conversation

@mikkel

@mikkel mikkel commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Depends on #522 (base: develop). This branch now contains #522 (merged in, with current develop); merge #522 first, then this diff reduces to the serving-boundary change.

Updated 2026-11-20: Stacked on #522. The 14 particlegan/policy.py consumers now carry a pr-520-audit-develop-integration-20261114 source-only layer whose previous_task_commit is the #522 head; the pr-522 layer and receipt are unchanged byte-for-byte. Binding tests walk stacked layers. Generated Forge reports regenerated with Forge tooling.

Export serving models only when the trainer is between updates.

A new snapshot now requires a valid update boundary, so its weights and counters describe the same state. A snapshot captured earlier remains usable while training continues. Applications own synchronization and publication. Pair with #522 to enforce checkpoint recovery before exporting after a failed update.

Updated 2026-11-09: Integrated current develop and its audit publication rules. Passed 19 serving/binding/metadata controls plus 242 model/comparison/policy-coverage controls; both published-report checks pass and lint is current. Original scientific rows, qualifications and exact source-binding receipts are preserved. No scientific campaign or regrading was performed. Full CI passes: 11 checks at 8a0f4629c6c7 (run).

Original technical notes and evidence

Serving exports could capture an active update whose weights, controls, averages, and completed-update counter described different stages. Require a completed policy boundary for served_snapshot() and served_model(), including the GANTrainer wrappers. Previously captured frozen models remain usable during training and inside generator_real.

The serving guide separates ParticleGAN's coherent source selection, live parameter swap, and bounded-stale certificate from the application's synchronization, publication, retention and rollback responsibilities. No deployment infrastructure, training mathematics, recipe or sampling changes.

Validation: the boundary regression failed before the guard; 85 serving/ownership/precision/routed/feature tests passed (3 opt-in tests deselected), 7 documentation checks passed, and the reviewed lint baseline and whitespace checks passed. Tests cover active phases without perturbing the update, callback inference using an existing copy, and average-to-fast expiry while a published copy stays independent.

Follow-up to audit #516. Interrupted-update recovery and particle-move preparation are separate PRs. The guard checks ordering; callers still serialize concurrent access.

@mikkel
mikkel force-pushed the refactor/serving-transition-contract branch from 8a0f462 to 95c8f4e Compare November 14, 2026 20:09
mikkel and others added 7 commits November 14, 2026 20:28
Include DDGAN repair and MiSGAN task declarations in the source-only provenance layer. Preserve historical layer ordering and original task bytes; no scientific outcomes or training laws change.
Include DDGAN repair and MiSGAN task declarations in the source-only provenance layer. Preserve historical layer ordering and original task bytes; no scientific outcomes or training laws change.
Take develop's generated Forge artifacts and regenerate EXPERIMENTS_BY_TIER,
EXPERIMENT_MEMORY and compilation.json with Forge tooling. The catalog
validates unchanged (history --check). Let the frozen-threshold test accept
the declared pr-522 source-only layer stacked over the combined integration
binding by walking the verified binding chain instead of requiring the
combined id at the top.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Take develop's generated memory/compilation and regenerate with Forge compile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…date-contract)

Merge the #522 branch (already merged with develop) so particlegan/policy.py
carries both changes. Rebind the 14 policy consumers as a pr-520 source-only
layer whose previous_task_commit is the #522 head (890d73f), leaving the
pr-522 layer and receipt byte-for-byte unchanged; the pr-520 receipt records
the stacked parent. Boundary-binding tests now walk stacked layers and verify
each receipt against its own layer and source commit. Regenerate
EXPERIMENTS_BY_TIER, EXPERIMENT_MEMORY and compilation.json with Forge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y source

Run regenerate_technique_inventory.py --refresh-publication (scientific rows
preserved, no regrade, no training) and Forge compile so family_progress and
generated pages bind the current policy/training sources.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Take #522's generated reports, then rerun regenerate_technique_inventory.py
--refresh-publication and Forge compile against this branch's policy.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant