chore: return null from getRootDir when hubspot.config.yml is not found#51
Merged
Merged
Conversation
Prevents a throw on CI machines where hubspot.config.yml does not exist, which caused Cypress to mark the config as invalid.
davidding
requested review from
TyStelmach,
alex-117,
cfrisoli,
craigayre,
darkmavis1980,
david-mooney,
denisolvr,
jbuitrago-hub,
mrndhlovu,
nhorilopchan and
swatinigam
denisolvr
approved these changes
Jun 29, 2026
davidding
changed the title
darkmavis1980
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getRootDirthrows when it reached the filesystem root without findinghubspot.config.yml.getRootDirnow returnsnullinstead of throwinggetDevBaseUrlbefore using the result