Skip to content

mkvtoolnix-app 98.0 (new structure)#264504

Open
Touchstone64 wants to merge 2 commits into
Homebrew:mainfrom
Touchstone64:main
Open

mkvtoolnix-app 98.0 (new structure)#264504
Touchstone64 wants to merge 2 commits into
Homebrew:mainfrom
Touchstone64:main

Conversation

@Touchstone64
Copy link
Copy Markdown

MKVToolNix now supports multiple Mac architectures with different packages, and the naming and location of all Mac packages have been updated. So, the cask needs updating.

Everything seems in order here, I can download and install the package, but this is my first Homebrew cask PR so if I've made any incorrect assumptions please let me know!


After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes, including zap stanza paths.

MKVToolNix now supports multiple Mac architectures with different
packages, and the naming and location of all Mac packages have been
updated. So, the cask needs updating.
Comment thread Casks/m/mkvtoolnix-app.rb Outdated
Comment thread Casks/m/mkvtoolnix-app.rb
Comment on lines +4 to +8
version "98.0-1"
sha256 arm: "38aad91a07166bb74a68d6920dc809135f863762cd8f883749f9c24cc34563a6",
intel: "4caeaed71d1066483ef43b05fe7ad51d7c5f2807e74afdc9ae27733cfa866024"

url "https://mkvtoolnix.download/macos/releases/#{version.split("-").first}/MKVToolNix-#{version}-#{arch}.dmg"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it'll have multiple releases I think this is the better way to handle it for now

Suggested change
version "98.0-1"
sha256 arm: "38aad91a07166bb74a68d6920dc809135f863762cd8f883749f9c24cc34563a6",
intel: "4caeaed71d1066483ef43b05fe7ad51d7c5f2807e74afdc9ae27733cfa866024"
url "https://mkvtoolnix.download/macos/releases/#{version.split("-").first}/MKVToolNix-#{version}-#{arch}.dmg"
version "98.0"
sha256 arm: "38aad91a07166bb74a68d6920dc809135f863762cd8f883749f9c24cc34563a6",
intel: "4caeaed71d1066483ef43b05fe7ad51d7c5f2807e74afdc9ae27733cfa866024"
url "https://mkvtoolnix.download/macos/releases/#{version}/MKVToolNix-#{version}-1-#{arch}.dmg"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the intention is that there may be multiple packages for a single version, should a problem arise with the packaging or the host OS. For example, MKVToolNix 98.0 is first packaged for arm64 (for example) as MKVToolNix-98.0-1-arm64.dmg. Should the packaging need to change then it would still contain an unmodified MKVToolNix 98.0 but be named MKVToolNix-98.0-2-arm64.dmg.

I can modify the cask by hand if that happens, but is there an issue keeping the version as 98.0-1?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we use a comma for that

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with keeping the hyphen in the version in this case, especially if it ends up not always being present. If we updated the version and livecheck to convert it to a comma, we have to reconvert it in the second part of the url anyway.

Copy link
Copy Markdown
Author

@Touchstone64 Touchstone64 May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we use a comma for that

Ah, that's my ignorance showing. The character we use isn't significant, but we do need the second part of the version for end users to get the update. (Presumably that's part of what Homebrew does with version, use it to determine whether an update is available?)

If you're both OK with the major.minor-revision syntax can we resolve this issue? @SMillerDev?

Comment thread Casks/m/mkvtoolnix-app.rb
Comment thread Casks/m/mkvtoolnix-app.rb
@Touchstone64 Touchstone64 requested a review from SMillerDev May 17, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants