feat(tui): Ctrl+S sends next queued message as a steer#3170
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the behavior of the Ctrl+S shortcut in the TUI. When the message queue is non-empty, Ctrl+S now pops and sends the next queued message as a steer instead of stashing. The localization descriptions have been updated to reflect this change. The review feedback suggests a minor optimization in crates/tui/src/tui/ui.rs to pass the formatted string directly to push_status_toast instead of a reference, avoiding an unnecessary clone.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| app.push_status_toast( | ||
| &format!("Steered queued message: {}", message.display), | ||
| StatusToastLevel::Info, | ||
| Some(3_000), | ||
| ); |
There was a problem hiding this comment.
Passing a reference to format! (&format!(...)) to push_status_toast is inefficient. Since push_status_toast accepts impl Into<String>, passing the String returned by format! directly avoids an unnecessary reference creation and subsequent string clone.
| app.push_status_toast( | |
| &format!("Steered queued message: {}", message.display), | |
| StatusToastLevel::Info, | |
| Some(3_000), | |
| ); | |
| app.push_status_toast( | |
| format!("Steered queued message: {}", message.display), | |
| StatusToastLevel::Info, | |
| Some(3_000), | |
| ); |
When the queued-messages bucket is non-empty, Ctrl+S now pops the front queued follow-up and steers it into the current turn. If the queue is empty the existing Ctrl+S stash behavior is preserved. - Adds a prioritized key arm before the stash handler. - Re-queues the message at the front on steer failure. - Updates English stash/queue keybinding help text.
Hmbown
force-pushed
the
feat/ctrl-s-send-queued-steer
branch
from
779e02a to
716af37
Compare
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
1 participant
Adds a Ctrl+S shortcut that pops the next queued follow-up and steers it into the current turn. When the queue is empty, Ctrl+S keeps its existing stash-draft behavior.\n\n- Prioritized key arm before the stash handler.\n- Re-queues the message at the front if the steer fails.\n- Updates English stash/queue keybinding help text.