Skip to content

🧪 Add test for ToolError::invalid_input#3136

Open
Hmbown wants to merge 1 commit into
mainfrom
add-test-for-tool-error-invalid-input-1334347659824431821
Open

🧪 Add test for ToolError::invalid_input#3136
Hmbown wants to merge 1 commit into
mainfrom
add-test-for-tool-error-invalid-input-1334347659824431821

Conversation

@Hmbown

@Hmbown Hmbown commented Jun 12, 2026

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed is the lack of unit tests for the ToolError::invalid_input constructor in crates/tools/src/lib.rs.
📊 Coverage: The test ensures that invalid_input produces the correct ToolError::InvalidInput enum variant with the provided message payload.
Result: Increased test coverage for tool error construction, ensuring no regressions in fundamental error types used throughout the tools crate.


PR created automatically by Jules for task 1334347659824431821 started by @Hmbown

This commit introduces a unit test for the `ToolError::invalid_input`
constructor to ensure it correctly maps to the `ToolError::InvalidInput`
variant with the expected message.

Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@Hmbown Hmbown added this to the v0.8.64 milestone Jun 13, 2026
pull Bot pushed a commit to dolfly/DeepSeek-TUI that referenced this pull request Jun 14, 2026
Harvests focused coverage from Hmbown#3136 and Hmbown#3138.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant