Skip to content

🧹 Extract setupOrgApiMock logic into smaller helper functions#1145

Merged
is0692vs merged 1 commit into
stagingfrom
code-health-setup-org-api-mock-14096522148886484374
Jul 22, 2026
Merged

🧹 Extract setupOrgApiMock logic into smaller helper functions#1145
is0692vs merged 1 commit into
stagingfrom
code-health-setup-org-api-mock-14096522148886484374

Conversation

@is0692vs

@is0692vs is0692vs commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

🎯 What: Extracted the massive setupOrgApiMock function into smaller helper functions (handleOrgRequests, handleMemberRequests, handlePaperRequests).

💡 Why: The setupOrgApiMock function was over 130 lines long and handled multiple entity types (org, members, papers) in a single large block of if statements. By extracting parts of the mock setup into smaller helpers, the code is much more readable and maintainable.

Verification: Ran the full test suite (pnpm run test) and confirmed all tests still pass, including the tests in apps/web/src/app/orgs/[slug]/settings/tests/page.test.tsx.

Result: Improved maintainability and readability by breaking down a large function into smaller, well-scoped helpers without changing behavior.


PR created automatically by Jules for task 14096522148886484374 started by @is0692vs

Greptile Summary

このPRは、org設定ページのテスト用APIモックを小さな関数に分割しています。

  • org関連リクエストを handleOrgRequests に分離。
  • member関連リクエストを handleMemberRequests に分離。
  • paper関連リクエストを handlePaperRequests に分離。
  • 検索用ユーザーとpaperの固定データをモジュール定数へ移動。

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/web/src/app/orgs/[slug]/settings/tests/page.test.tsx 既存の setupOrgApiMock を helper 関数に分割し、同じモックレスポンスと状態更新を維持しています。

Reviews (1): Last reviewed commit: "🧹 Extract setupOrgApiMock logic into sm..." | Re-trigger Greptile

Context used:

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 22, 2026 03:57
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
open-shelf Ignored Ignored Jul 22, 2026 3:57am

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@dosubot dosubot Bot added the javascript Pull requests that update javascript code label Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@is0692vs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 011b6767-c218-42fc-9e43-e4a1312caadc

📥 Commits

Reviewing files that changed from the base of the PR and between a3eea8f and 76ddc81.

📒 Files selected for processing (1)
  • apps/web/src/app/orgs/[slug]/settings/__tests__/page.test.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch code-health-setup-org-api-mock-14096522148886484374

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

このリポジトリでは staging 先行フローを採用しています。PR のターゲットを staging に変更しました。staging で動作確認後、stagingmain の PR を作成してください。

@github-actions
github-actions Bot changed the base branch from main to staging July 22, 2026 03:57
@is0692vs
is0692vs merged commit 3c9fdc9 into staging Jul 22, 2026
24 checks passed
@is0692vs
is0692vs deleted the code-health-setup-org-api-mock-14096522148886484374 branch July 22, 2026 04:06
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants