Skip to content

🎨 Palette: Markdownエディタのキーボードアクセシビリティを改善#1140

Closed
is0692vs wants to merge 4 commits into
stagingfrom
palette/improve-markdown-editor-a11y-3370455494153938501
Closed

🎨 Palette: Markdownエディタのキーボードアクセシビリティを改善#1140
is0692vs wants to merge 4 commits into
stagingfrom
palette/improve-markdown-editor-a11y-3370455494153938501

Conversation

@is0692vs

@is0692vs is0692vs commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

💡 What: Markdownエディタのタブボタン、テキストエリア、およびプレビューパネルにキーボードフォーカス時の視認性を高めるスタイル(フォーカスリング)を追加し、プレビューパネルにもタブでフォーカス可能にしました。
🎯 Why: <textarea>focus:outline-none が指定されており、キーボード操作時にどこにフォーカスが当たっているか視覚的に判別できなくなっていた問題を解消するため。
📸 Before/After: フォーカス時にインジケーターが表示されなかった状態から、要素の内側にフォーカスリングが表示されるように改善されました。
Accessibility: WCAGのフォーカス視認性の要件を満たすため、各要素に focus-visible:ring-2 focus-visible:ring-inset 等を追加し、tabpaneltabIndex={0} を付与してキーボードナビゲーションを可能にしました。


PR created automatically by Jules for task 3370455494153938501 started by @is0692vs

Greptile Summary

This PR improves keyboard focus styling in the Markdown editor.

  • Adds visible keyboard focus rings to the Write and Preview tab buttons.
  • Adds a visible keyboard focus ring to the editor textarea.
  • Records the Markdown editor accessibility guidance in the palette notes.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/web/src/components/markdown-editor.tsx Adds keyboard-visible focus styling to the Markdown editor controls without changing the tab state or editing flow.
.Jules/palette.md Adds a palette note for Markdown editor keyboard accessibility guidance.

Reviews (3): Last reviewed commit: "Merge branch 'staging' into palette/impr..." | Re-trigger Greptile

Context used:

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 21, 2026 14:54
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
open-shelf Ignored Ignored Jul 22, 2026 4:02am

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@is0692vs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ed312b03-3a2d-47c6-8659-7ad29275770a

📥 Commits

Reviewing files that changed from the base of the PR and between a384f46 and 31055aa.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (21)
  • .Jules/palette.md
  • .github/workflows/check-migrations.yml
  • .github/workflows/check-ruleset-drift.yml
  • .github/workflows/ci.yml
  • .github/workflows/cleanup-stale-workflows.yml
  • .github/workflows/codeql.yml
  • .github/workflows/deploy-api.yml
  • .github/workflows/enforce-staging-flow.yml
  • .github/workflows/osv-auto-fix.yml
  • .github/workflows/promote-staging-to-main.yml
  • .github/workflows/sync-main-to-staging.yml
  • apps/api/package.json
  • apps/api/src/routes/__tests__/invites.test.ts
  • apps/api/src/routes/__tests__/papers.test.ts
  • apps/api/src/routes/invites.ts
  • apps/api/src/routes/papers.ts
  • apps/web/package.json
  • apps/web/src/app/__tests__/collections-new.test.tsx
  • apps/web/src/app/__tests__/orgs-new.test.tsx
  • apps/web/src/components/markdown-editor.tsx
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/improve-markdown-editor-a11y-3370455494153938501

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dosubot dosubot Bot added the enhancement New feature or request label Jul 21, 2026
@github-actions
github-actions Bot changed the base branch from main to staging July 21, 2026 14:54
@github-actions

Copy link
Copy Markdown

このリポジトリでは staging 先行フローを採用しています。PR のターゲットを staging に変更しました。staging で動作確認後、stagingmain の PR を作成してください。

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the keyboard accessibility of the MarkdownEditor component by adding focus-visible styles to the tab buttons, the textarea, and the preview panel, and documents these practices in .Jules/palette.md. Feedback was provided regarding the addition of tabIndex={0} to the preview panel: since the panel is not configured to be scrollable, adding a tab stop creates an unnecessary keyboard navigation step. It is recommended to either remove the tabIndex and focus styles or make the panel scrollable.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/web/src/components/markdown-editor.tsx Outdated
@is0692vs

Copy link
Copy Markdown
Contributor Author

@greptile review

@is0692vs

Copy link
Copy Markdown
Contributor Author

@greptile review

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
@pull-request-size pull-request-size Bot added size/L and removed size/S labels Jul 22, 2026
@is0692vs

Copy link
Copy Markdown
Contributor Author

Closing because Jules re-appended a duplicate implementation commit after the reviewed fix and staging merge. This automation-induced history contamination makes the branch unstable and includes unrelated staging changes.

@is0692vs is0692vs closed this Jul 22, 2026
@is0692vs
is0692vs deleted the palette/improve-markdown-editor-a11y-3370455494153938501 branch July 22, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants