Skip to content

Re-authorize with the catalog's current scopes; hints for missing scopes and Odoo fields; clearer unverified-email refusal on /mcp - #978

Merged
helpcodeai merged 1 commit into
mainfrom
fix/etsy-scopes-verify-hint
Oct 10, 2026
Merged

helpcodeai merged 1 commit into
mainfrom
fix/etsy-scopes-verify-hint

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

From the 10 Oct review of the last 16 hours on Cloud.

  1. Etsy write tools fail with "lacks scope listings_w" (19 calls, 3 workspaces). Connectors installed before the write tools still store the read-only scopes (116 of 364 Etsy connectors on Cloud), and since the catalog re-sync never touches authConfig, re-authorizing asked for the old list again.
    • New adapter field previousOAuthScopes: the scope sets the adapter asked for before.
    • A connector holding exactly one of them asks for the current scopes on its next Authorize with Provider. The new set is written back like any adopted value.
    • A hand-picked subset is kept as it is.
    • Etsy lists its old set. No customer data is changed: the user only has to authorize again.
  2. Hints in tool errors:
    • any error naming a missing scope (lacks scope, insufficient_scope, ...) tells the model to have the user re-authorize instead of retrying;
    • an unknown Odoo field (Invalid field 'x' on 'model', also in JSON-RPC leaves) points to odoo_fields_get, which was 7 workspaces in 16 h;
    • an unknown model (stock.production.lot → stock.lot) says it was renamed or its app is not installed.
  3. Unverified email on /mcp: 7 people who connected Claude retried up to 122 times and only saw "Email verification required". The refusal now tells them to confirm the email or sign in at the dashboard for a new link.
  4. Log noise: "Duplicate tool name" is logged at most once an hour per server and tool name. One polling client produced 1,880 lines in 16 h.

Tests: new cases for each change; full backend suite 10,763 passed; tsc and validate-adapters clean.

@helpcodeai
helpcodeai requested a review from D3nisty as a code owner October 10, 2026 09:39
@github-actions

Copy link
Copy Markdown

👋 Welcome, @helpcodeai, and thanks for opening your first PR on AnythingMCP!

A few quick pointers:

  • Make sure CI is green before requesting review (Backend, Frontend, Playwright, CodeQL, Trivy).
  • If this is a new adapter, the parametrised catalog.spec.ts test will validate it automatically.
  • Sign off your commits if you can — it's not blocking, just nice to have.

Someone from the core team will look at this within ~48h. If you don't hear back, please ping us in Discussions / Q&A.

⭐ While you wait — if you find AnythingMCP useful, a star helps others discover it.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@helpcodeai

Copy link
Copy Markdown
Contributor Author

recheck

@helpcodeai
helpcodeai force-pushed the fix/etsy-scopes-verify-hint branch from a583ad2 to 635ee86 Compare October 10, 2026 09:44
…sing scopes and unknown Odoo fields; clearer /mcp refusal for unverified email; one duplicate-name log per hour

- Etsy connectors installed before the write tools kept the old read-only
  scopes in authConfig (116 of 364 on Cloud), so re-authorizing could never
  grant listings_w. An adapter can now list the scope sets it used to ask for
  (previousOAuthScopes); a connector holding exactly one of them asks for the
  current scopes on its next authorization. Hand-picked subsets are kept.
- Tool errors that name a missing scope tell the model to have the user click
  Authorize with Provider again; unknown Odoo fields and models point at the
  field list (7 workspaces in 16 h).
- An unverified user calling /mcp now reads what to do (confirm the email or
  sign in for a new link) instead of a bare "Email verification required".
- "Duplicate tool name" is logged once an hour per server and name (1,880
  lines in 16 h from one polling client).
@helpcodeai
helpcodeai force-pushed the fix/etsy-scopes-verify-hint branch from 635ee86 to f43e807 Compare October 10, 2026 11:19
@helpcodeai
helpcodeai merged commit c56d32f into main Oct 10, 2026
2 checks passed
@helpcodeai
helpcodeai deleted the fix/etsy-scopes-verify-hint branch October 10, 2026 11:19
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant