Repository navigation
Make the hdp-mcp expired-record test deterministic - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the hdp-mcp test "does not treat an expired record as an integrity failure" deterministic. Test-only change.
The test waited with one
setTimeoutuntil just pastheader.expires_at, then assertedexpires_at < Date.now(). Node timers can fire about 1 ms early, soDate.now()could equalexpires_atand the strict assertion failed. This happened on public CI run 37796834941 (Node 22):expected 1791471505561 to be less than 1791471505561.The test now waits in 1 ms steps until
Date.now()is pastexpires_at, so the strict assertion holds by construction. What the test proves is unchanged: an expired, correctly signed record is reported throughonValid,onInvalidis not called, and the handler runs.Verification:
onInvalid, the test fails (onValidnot called); the change was reverted and confirmed clean before the green runs.