Skip to content

Reduce applyStyles when adding/removing a child #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Speedphoenix wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce applyStyles when adding/removing a child #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions domkit/CssStyle.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,8 @@ class CssStyle {

for( r in rules ) {
if( !ruleMatch(r.cl,e) ) continue;
if(r.cl.pseudoClasses.has(NeedChildren) && e.parent != null)
e.parent.hasNeedChildren = true;
var i = r.style.length - 1;
while( i >= 0 ) {
var p = r.style[i--];
Expand Down Expand Up @@ -591,6 +593,8 @@ class CssStyle {
// parent style has changed, we need to sync children
force = true;
}
if (force)
e.hasNeedChildren = false;
var obj : Model<Dynamic> = e.obj;
for( c in @:privateAccess obj.getChildren() ) {
var c : Model<Dynamic> = c;
Expand Down
3 changes: 2 additions & 1 deletion domkit/Properties.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ class Properties<T:Model<T>> {
var dirtyPrev : Properties<T>;
var dirtyNext : Properties<T>;
var depth : Int = 0;
var hasNeedChildren = false;

static var KEEP_VALUES = false;

Expand Down Expand Up @@ -138,7 +139,7 @@ class Properties<T:Model<T>> {
if( p == null ) {
dirty = new DirtyList<T>();
depth = 0;
if( prev != null )
if( prev != null && prev.hasNeedChildren)
prev.needRefresh(); // can change :first-child etc.
} else {
dirty = p.dirty;
Expand Down