halobject: replace traceback with a call to logging system instead#99
Closed
richteer wants to merge 1 commit into
Closed
halobject: replace traceback with a call to logging system instead#99richteer wants to merge 1 commit into
richteer wants to merge 1 commit into
Conversation
If there is an unhandled exception in a _receive() handler, error should be logged instead of just printed to the console. This should also play nicer with cli/gui wrappers as well.
Contributor
Author
|
Closing this, #98 contains the same commit, which that branch is what this was written for in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is an unhandled exception in a _receive() handler, error should be
logged instead of just printed to the console. This should also play nicer
with cli/gui wrappers as well.