Skip to content

Load config file in the Config class#134

Merged
sjrct merged 1 commit into
masterfrom
config-load-in-Config
Mar 5, 2019
Merged

Load config file in the Config class#134
sjrct merged 1 commit into
masterfrom
config-load-in-Config

Conversation

@richteer

@richteer richteer commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Simple PR to move the config loading logic into the Config class itself. Since this class should be relatively self-contained, it seemed to be more appropriate there than in Halibot.

I kept Halibot._load_config() and Halibot._write_config() as a simple redirect. Halibot should still control when to read/write the config, and also should be controller of the current working directory. Thus, workdir is an optional parameter that is automatically filled by the stub functions on the Halibot class, but required for any direct calls to Halibot.config._load_config().

@richteer
richteer force-pushed the config-load-in-Config branch from ca6b166 to 118cc24 Compare March 5, 2019 14:47
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 93.061% when pulling 118cc24 on config-load-in-Config into d940184 on master.

@sjrct
sjrct merged commit f55bd17 into master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants