Load config file in the Config class#134
Merged
Merged
Conversation
richteer
force-pushed
the
config-load-in-Config
branch
from
March 5, 2019 14:47
ca6b166 to
118cc24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple PR to move the config loading logic into the
Configclass itself. Since this class should be relatively self-contained, it seemed to be more appropriate there than inHalibot.I kept
Halibot._load_config()andHalibot._write_config()as a simple redirect.Halibotshould still control when to read/write the config, and also should be controller of the current working directory. Thus,workdiris an optional parameter that is automatically filled by the stub functions on theHalibotclass, but required for any direct calls toHalibot.config._load_config().