halauth: adds regex support for ri and perm fields of permissions#125
Merged
Conversation
sjrct
approved these changes
Jan 31, 2019
Member
|
This will break previous instances of |
Contributor
|
Hmmm, I think I'm fine with breaking that compatibility as well. As far as I am aware, no one uses permissions right now anyway. We could keep the special case for |
richteer
approved these changes
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can probably rework the permissions loading system as well to better handle regexes, making this more robust. Feel free to leave on comments on any ideas you might have.