halibot: adds repr and str functions for message class#123
Merged
Conversation
richteer
approved these changes
Oct 5, 2018
sjrct
reviewed
Jan 31, 2019
| return '/'.join(self.target.split('/')[1:]) | ||
|
|
||
| def __repr__(self): | ||
| return "halibot.Message(body='{}', type='{}', author='{}', identity='{}', origin='{}', misc='{}', target='{}')".format(self.body, self.type, self.author, self.identity, self.origin, self.misc, self.target) |
Member
There was a problem hiding this comment.
f"halibot.Message(body='{self.body}', ...)" would be better.
sjrct
approved these changes
Jan 31, 2019
Member
|
I only took three months since the end of Hacktoberfest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps we can open up some discussion for how we want to show message information but we can utilize both repr() (for verbose object printing) and str() (for readable object printing) if we want, but what we want to display in str() is up for discussion. Also, I'm not sure what the process is for adding new tests but I wanted to verify I could recreate a message from repr(). If the tests don't make sense or should go somewhere else, please let me know.
Also, for reference: #97