halibot: Changes use-auth parameter from kwarg to config param, adds …#120
Merged
Conversation
…more error-proofing for faulty permissions file
richteer
approved these changes
Oct 4, 2018
richteer
left a comment
richteer
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Unrelated, but something to consider -- "Auth" and "Permissions" are being used interchangably, we should probably unify that. I think "Permissions" is the more clear one, since that's a better description of how the system works. I may open an issue in the future to change that before perm usage gets too widespread to change
sjrct
approved these changes
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…more error-proofing for faulty permissions file
For #118