Refactor cms-loader to use async/await for clarity#922
Open
raisakshii wants to merge 2 commits into
Open
Conversation
Author
|
could you please review this PR when you get a chance? |
lavjeetrai
approved these changes
Jun 4, 2026
Author
|
thanks for review.i have converted it into draft .i'll reopen it when i 'll fix the errors |
e8134a4 to
6e9d3b3
Compare
Author
|
@EdwardMoyse , could you please review this PR when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the
readIgArchivemethod inCMSLoaderto use modern asynchronous patterns (async/awaitandPromise.all). This resolves a potential race condition during file parsing and significantly improves code readability.Key Changes
let i = 1) withPromise.allto guarantee all files are completely unzipped and parsed before triggering theonFileReadcallback..then()chains to a flatasync/awaitcontrol flow, eliminating callback hell.try/catchblock around the archive parsing logic to ensure theloadingManagerresolves gracefully even if the.igfile is corrupt.