Skip to content

feat: add masterclass panel and ATLAS masterclass landing page (close…#920

Merged
EdwardMoyse merged 1 commit into
HSF:mainfrom
rx18-eng:feat/masterclass-and-landing-page-915
Jun 6, 2026
Merged

feat: add masterclass panel and ATLAS masterclass landing page (close…#920
EdwardMoyse merged 1 commit into
HSF:mainfrom
rx18-eng:feat/masterclass-and-landing-page-915

Conversation

@rx18-eng

@rx18-eng rx18-eng commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Body

closes #835 and #915 in one PR. #835 was stale (branch drifted too far to rebase practically), so i rebuilt the masterclass code on a fresh branch from main instead.

what's in

  • masterclass tagging panel. opt-in via uiConfig.showMasterclassPanel (default false so /atlas etc stay unchanged). tag particles, live invariant mass, results history.
  • /atlas-masterclass route with a reduced bar. same atlas detector + event as /atlas. drops vr, ar, animate, clipping, overlay, share, make-picture. more info menu keeps info panel, event browser, eta-phi, kinematics (drops collections info + geometry browser).
  • landing card between atlas and lhcb pointing to the new route.
  • on() / emit() event bus on EventDisplay (addresses part of Allow easier integration of phoenix in other applications #826). standard events fired:
    • particle-tagged
    • particle-untagged
    • result-recorded

not in (intentionally)

Recording.2026-06-02.002754.1.1.1.mp4

…HSF#835, closes HSF#915)

Signed-off-by: rx18-eng <remopanda78@gmail.com>
@rx18-eng rx18-eng requested a review from EdwardMoyse June 1, 2026 19:21
@rx18-eng

rx18-eng commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@EdwardMoyse Let me know your thoughts on this !

@rx18-eng rx18-eng added this to the 4.1.0 milestone Jun 2, 2026
@EdwardMoyse EdwardMoyse modified the milestones: 4.1.0, Release 4.0.0 Jun 6, 2026
@EdwardMoyse

Copy link
Copy Markdown
Member

This looks great. I think we should get this in now, then I can share it with some masterclass folk. We can implement any feedback for 4.1.0

@EdwardMoyse EdwardMoyse merged commit 0ac0a78 into HSF:main Jun 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants