Skip to content

Refactor edm4hep JSON loader#821

Merged
EdwardMoyse merged 35 commits into
HSF:mainfrom
apausa:check-process
May 31, 2026
Merged

Refactor edm4hep JSON loader#821
EdwardMoyse merged 35 commits into
HSF:mainfrom
apausa:check-process

Conversation

@apausa

@apausa apausa commented Mar 12, 2026

Copy link
Copy Markdown
Contributor
  • Refactor EDM4HEP JSON loader
  • Add type support for every schema
  • Integrate all schema types in edm4hep.ts

@apausa apausa closed this Mar 12, 2026
@apausa apausa reopened this Mar 16, 2026
@apausa apausa changed the title Refactor edm4hep JSON loader [WIP] Refactor edm4hep JSON loader Mar 16, 2026
@apausa apausa closed this Mar 16, 2026
@apausa apausa reopened this Mar 16, 2026
@EdwardMoyse

EdwardMoyse commented Mar 26, 2026

Copy link
Copy Markdown
Member

Hey @apausa - not sure if you saw that the CI was failing? You can test this locally with yarn test:ci as described here: https://github.com/HSF/phoenix/blob/main/guides/developers/test-setup.md#running-the-tests-locally

@EdwardMoyse

Copy link
Copy Markdown
Member

Ping @apausa

@apausa

apausa commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Hi @EdwardMoyse, I apologize for my late response, as my notifications were incorrectly configured. I hope to resolve this today. Thank you very much.

@apausa

apausa commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Hi @EdwardMoyse, the tests pass on my machine... They do fail when projects/phoenix-ui-components/dist is present, as both projects/phoenix-ui-components/package.json and projects/phoenix-ui-components/dist/package.json share the same name, which Jests finds conflicting :)

@apausa apausa changed the title [WIP] Refactor edm4hep JSON loader Refactor edm4hep JSON loader Apr 10, 2026
apausa and others added 4 commits May 13, 2026 16:44
@EdwardMoyse

Copy link
Copy Markdown
Member

@apausa Apologies for the long delay here

@EdwardMoyse EdwardMoyse merged commit 75e97fc into HSF:main May 31, 2026
2 checks passed
@apausa apausa deleted the check-process branch June 1, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants