Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recode32binary that converts PolyML's 64-bit.trheap dumps to a 32-bit narrow format, halving the size of pointers and headersTR32\0\0\0\xFF; the final byte cannot collide with a valid 64-bit flags byte (which is always 00–03)ProofTraceParsergains aHeap32variant that decodes the narrow format in-place; allsh*accessors dispatch on the variantTracing.exportpipes throughrecode32when the (default-on)recode_32bitflag is setFailrather than silently truncating when a value does not fit in 32 bitsrecode32is built automatically by Holmake (viaPOLYC) into$HOLDIR/bin/recode32when--trknlis enabled, sincesrc/tracing/yesis in the kernel sequence for that buildTest plan
--trknland confirm$HOLDIR/bin/recode32is produced.tr.gzfiles are roughly half the size of the 64-bit formatProofTraceParser.parsedecodes the new files correctly viaProofTraceReplay