Skip to content

Add additional fast sky-based calibration to abscal module#892

Open
tyler-a-cox wants to merge 13 commits into
mainfrom
skycal
Open

Add additional fast sky-based calibration to abscal module#892
tyler-a-cox wants to merge 13 commits into
mainfrom
skycal

Conversation

@tyler-a-cox

@tyler-a-cox tyler-a-cox commented Apr 30, 2023

Copy link
Copy Markdown
Contributor

This PR adds a new sky-based calibration function to the abscal module. There are currently functions for performing traditional sky-based calibration (amp_logcal and phs_logcal), but both are quite slow as they involve matrix inversions. This new function, sky_calibration, implements the StEfCal algorithm (Salvini et al 2014) which scales as nants^2. Below is a time comparison between the existing abscal functions and the new method

Screenshot 2023-04-30 at 3 04 39 PM

And here is a comparison of the residuals of the two methods, showing nearly identical results for the two approaches

Screenshot 2023-04-29 at 8 06 22 PM

I also tested on H6C data using redundantly-calibrated, redundantly-averaged data as the sky model and found that the redundantly-calibrated data and sky-calibrated data agree quite well. Below are the delay-transformed redundantly calibration and sky-calibrated visibilities for a single baseline type.

Screenshot 2023-11-03 at 9 11 31 PM

@codecov

codecov Bot commented Apr 30, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.21%. Comparing base (3286222) to head (3447972).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   97.19%   97.21%   +0.02%     
==========================================
  Files          31       31              
  Lines       11573    11657      +84     
==========================================
+ Hits        11248    11332      +84     
  Misses        325      325              
Flag Coverage Δ
unittests 97.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tyler-a-cox tyler-a-cox marked this pull request as ready for review May 1, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant