Conversation
GyulyVGC
requested changes
Aug 31, 2026
Address review feedback: drop the RunningPageShortcut message and emit the existing ChangeRunningPage from the Ctrl+1/2/3 shortcuts. The side-effect guard moves into change_running_page so the tab-bar path is covered too. Two existing tests drove ChangeRunningPage from states the guard now rejects (no running page / settings open); they set the state explicitly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
The requested refactor is now in the latest commit: the shortcuts reuse \ChangeRunningPage, and the shared handler owns the side-effect guard. The related tests now set the state required by that guard. Could you please re-review when convenient? |
Owner
|
Hey, thanks for the reminder I already reviewed actually and everything looks good, but it'll take some time to merge this since I'm working on other items right now. Hopefully I'll ship this with the next version of Sniffnet |
Owner
|
Hey @m-altaifi I think this should be extended to work also with setting pages as I'm doing for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
link.execannot findwpcap.lib)Refs #97