(fix): ui-toolkit - Select component added readOnly prop#329
Open
rohangupta-groww wants to merge 2 commits into
Open
(fix): ui-toolkit - Select component added readOnly prop#329rohangupta-groww wants to merge 2 commits into
rohangupta-groww wants to merge 2 commits into
Conversation
rohangupta-groww
mannequin
requested review from
ayush-mani-tripathi,
Amit-Groww and
shivesh-raj-nigam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are many cases when we just need to display data to user and take input from existing data. Here we require
readOnlywhen the data is being set programmatically. If not handled then it will display a keyboard and text input selection to user.What packages have been affected by this PR?
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyBugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Package version increase in any of the packages?
0.4.7Checklist before merging
Put an
xin the boxes that applyThese changes have been thoroughly tested.
Changes need to be immediately published on npm.