Skip to content

Add better handling for edge cases#209

Open
shuvamkr wants to merge 2 commits into
developfrom
fix/ella-function-edge-cases
Open

Add better handling for edge cases#209
shuvamkr wants to merge 2 commits into
developfrom
fix/ella-function-edge-cases

Conversation

@shuvamkr

@shuvamkr shuvamkr mannequin commented Mar 31, 2023

Copy link
Copy Markdown
Mannequin

What does this PR do?

Have made the following changes:

  • isEmpty() : Removed unnecessary checks. handled the case for Set and Map.
  • getSelectedTabIndex(): Added type checks for input and also optimised the approach with findIndex()
  • downloadFile(): Handled the case for invalid download method provided

What packages have been affected by this PR?

  • Ella

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Package version increase in any of the packages?

Checklist before merging

Put an x in the boxes that apply

  • These changes have been thoroughly tested.

  • Changes need to be immediately published on npm.

@shuvamkr shuvamkr mannequin self-assigned this Mar 31, 2023
@shuvamkr shuvamkr mannequin added enhancement New feature or request refactor Code cleanup / Updating legacy code labels Mar 31, 2023
Comment thread packages/ella/src/general/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Code cleanup / Updating legacy code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants