Skip to content

Fix sign/players toggle not appearing in non-overworld render views.#112

Merged
stwalkerster merged 1 commit into
GregoryAM-SP:mainfrom
derek-keeler:dek/fix-sign-toggle
Apr 9, 2026
Merged

Fix sign/players toggle not appearing in non-overworld render views.#112
stwalkerster merged 1 commit into
GregoryAM-SP:mainfrom
derek-keeler:dek/fix-sign-toggle

Conversation

@derek-keeler

Copy link
Copy Markdown
Contributor

Update javascript to load the 'Players / Signs' toggle element in the UI in all views.
Fixes #110

@stwalkerster

Copy link
Copy Markdown
Collaborator

This fix looks sensible enough to me and I'm happy to accept it as-is, though I'm unclear on what precisely was wrong for this to fix?

I don't think I've observed this in map renders I've done, and some of them make extensive use of the map markers with Overviewer config files reaching into the hundreds of lines of code.

@derek-keeler

Copy link
Copy Markdown
Contributor Author

Interesting. I haven't been seeing signs be rendered in the Nether or End views for some time. When I began this work I wasn't seeing them (as per usual) and after the fix I now see them.

Have you been seeing sign markers in the Nether? That would be the first thing to look at on your end. Second thing I can think of is what your default browser / OS is? I use Firefox (dev nightly) on Windows. Perhaps that's the source of the trouble as well (this may not have manifested on Chrome, for example).

@stwalkerster

Copy link
Copy Markdown
Collaborator

My default browser is Firefox (stable, Linux), markers do indeed appear in the Nether and the End, though as I mentioned earlier there is some really complex config on that render for all the map functionality.

I'll just merge this since it seems safe and sensible enough, though I am really curious what's going on (either why it was broken for you, or why it worked fine for me).

@stwalkerster stwalkerster merged commit dc09dab into GregoryAM-SP:main Apr 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signs toggle isn't working on non-overworld views on the web UI

2 participants