FIX BLOOM SAFE MODE#5128
Open
screret wants to merge 3 commits into
Open
Conversation
not ending vertices, causing buffer overflows.
the vertex buffer expects ARGB color
screret
added a commit
to screret/GregTech-Modern
that referenced
this pull request
Jul 17, 2026
htmlcsjs
added
ignore changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, this is awkward.
What
...not ending vertices, causing buffer overflows.
Also removed an erroneous color conversion in the same mixin and added a missing write lock check.
Implementation Details
It's quite simple, really.
AI Usage
Outcome
bloom appears and game doesn't crash after 30s
How Was This Tested
Ran game, looked, waited
Additional Information
Don't cherrypick this to 1.21, I'll PR a separate fix that includes these as well as a bunch of other stuff with bloom shortly.