Write PdfX4Test's profiles and documents to a directory of each test's own - #508
Merged
Merged
Conversation
…s own The test wrote its ICC profiles and output files to fixed names in the system temp directory, and its tear_down() deleted every mpdf-test-*.icc there. Two runs side by side removed each other's profiles mid-test and failed with unlink() and missing-file errors. Each test now works in a directory of its own under the temp directory and removes only that. The file names are kept, as the titles the tests check are taken from them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PdfX4Testwrote its ICC profiles and output files to fixed names in the system temp directory, andtear_down()deleted everympdf-test-*.iccthere. When two suites ran on one machine at the same time, each deleted the other's profiles partway through a test, causingunlink()and missing-file errors. Several agents working on the open bug PRs hit this. CI doesn't, because each job runs alone.Each test now makes its own directory under the temp directory (
uniqid('', true), asCacheDirectoryRaceTestdoes) and removes only that directory intear_down(). The file names are unchanged, because the titles the tests check (mpdf-test-untitled,Quarterly Report,/Info (mpdf-test-cmyk)) are taken from them.tests/Mpdf/PdfX4Test.phppasses (95 tests) and leaves no directory behind. Test-only change.🤖 Generated with Claude Code