Stop dispatching Build libheif from the release check - #4
Merged
Merged
Conversation
A PR opened with GITHUB_TOKEN does create a pull_request run; it waits for maintainer approval. That pending run is what the PR's checks show, so the dispatched run's result was never visible and each update built twice. Point the PR description and Slack message at approving the run instead, and drop the actions: write permission the dispatch needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2, based on the end-to-end test in #3.
What the test showed
update-libheif.ymldispatched Build libheif on each PR branch because I'd assumed a PR opened withGITHUB_TOKENdoesn't triggerpull_requestworkflows. It does. GitHub creates the run and holds it as action required until a maintainer approves it.On #3 that caused two problems:
pull_requestrun is what the PR's checks show. It has the same job name as the dispatched run, so the dispatched run's success was never visible on the PR.Changes
gh workflow run build-libheif.ymland theactions: writepermission it needed.actionlintpasses. The update flow is otherwise unchanged from the tested run.🤖 Generated with Claude Code