Repository navigation
fix(export): report incomplete protected backups - #3770
Open
oleksii-tumanov wants to merge 2 commits into
Open
oleksii-tumanov wants to merge 2 commits into
oleksii-tumanov wants to merge 2 commits into
Conversation
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3769.
An incomplete protected backup now warns which files failed and returns
None, instead of reporting success. Other files are still copied, and the caller can continue with its overwrite.Same-day reuse checks every selected artifact so an unchanged graph cannot hide a failed sidecar copy on retry. Comparison errors still allow a copy attempt, and closed output streams do not change the backup result. Eligibility and daily retention are unchanged.
Type of change
How was this tested?
The new regressions fail on the base and pass with this change. A read-only backup-file reproduction now reports failure without printing success.
The full suite ran: 5,927 passed, 15 skipped, 16 failed because the optional Erlang/R/Solidity/VB.NET grammar dependencies could not be downloaded. The same 16 failures reproduce on the unmodified base. All five skillgen guards and
graphify update .completed.Graphify-specific checklist