Repository navigation
Conversation
![graphify-labs[bot]](https://avatars.githubusercontent.com/in/4356270?s=60&v=4){kind=small}
There was a problem hiding this comment.
Graphify reviewed this change.
Worth a look — the grounded gate found no coupling regressions or blocking issues, but 2 advisory finding(s) below merit a look before merge.
Graphify review — findings
Adds Visual Basic .NET as a first-class language across the pipeline. A new extract_vbnet walks .vb files with the tree-sitter-vb-dotnet grammar to emit type, method, and call structure, and returns an error dict (rather than failing) when the grammar isn't installed, with _EXTRA_FOR_EXTENSION pointing users at the vbnet extra; resolve_vbnet_partial_calls links calls across files that declare the same partial type when exactly one candidate method matches by owner/name/arity (case-folded). Wires .vb into extension recognition (CODE_EXTENSIONS, _LANG_FAMILY/_LANG_FAMILY_BY_EXT as dotnet, case-insensitive identifiers, dispatch, and the extractor registry) and registers the partial-call resolver.
Worth a look
- VB.NET method indexing uses nonexistent list attribute —
graphify/extractors/vbnet.py:300· Escalate · high- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
- Unconditional vbnet import can break graphify.extract import —
graphify/extract.py:63· Escalate · high- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 2975 functions depend on the 424 functions this change touches.
Health — this change adds coupling hotspots:
- new:
extract()— 661 callers, 45 callees - new:
_rebuild_code()— 142 callers, 54 callees - new:
detect()— 112 callers, 15 callees - new:
to_obsidian()— 38 callers, 14 callees - new:
_extract_generic()— 18 callers, 29 callees - new:
save_manifest()— 40 callers, 11 callees - new:
to_json()— 58 callers, 7 callees - new:
extract_js()— 87 callers, 4 callees - …and 78 more — each is listed as a finding
Verification — 2975 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 2672 function(s) in the blast radius were not formally verified this run
Test selection
Test selection
291 of 291 test file(s) selected (100%) via static blast radius.
Escalated to a full run for safety — the selection is not trustworthy on its own (see below). CI should run the whole suite.
tests/test_affected_cli.py— full-run-safetytests/test_affected_member_seed.py— full-run-safetytests/test_agents_platform.py— full-run-safetytests/test_analyze.py— impact, full-run-safetytests/test_anthropic_custom_endpoint.py— full-run-safetytests/test_antigravity_install.py— full-run-safetytests/test_apm_fallback_version.py— full-run-safetytests/test_architecture_doc.py— full-run-safetytests/test_astro_extraction.py— impact, full-run-safetytests/test_astro_import_ids.py— impact, full-run-safetytests/test_atomic_canvas_export.py— impact, full-run-safetytests/test_atomic_version_stamp.py— full-run-safetytests/test_atomic_writes.py— impact, full-run-safetytests/test_backend_env_isolation.py— full-run-safetytests/test_backend_extras.py— full-run-safetytests/test_benchmark.py— full-run-safetytests/test_benchmark_raw_graph.py— full-run-safetytests/test_build.py— impact, full-run-safetytests/test_build_merge_dedup_scope.py— full-run-safetytests/test_build_merge_hyperedges_and_prune.py— full-run-safetytests/test_build_merge_shrink_guard.py— full-run-safetytests/test_builtin_global_type_refs.py— impact, full-run-safetytests/test_cache.py— full-run-safetytests/test_callflow_html.py— full-run-safetytests/test_cargo_introspect.py— full-run-safetytests/test_carried_hyperedge_remap.py— impact, full-run-safetytests/test_case_sensitive_resolution.py— impact, full-run-safetytests/test_charmap_encoding.py— impact, full-run-safetytests/test_chunking.py— impact, full-run-safetytests/test_cjs_module_extension.py— impact, full-run-safetytests/test_claude_cli_backend.py— impact, full-run-safetytests/test_claude_md.py— full-run-safetytests/test_cli_broken_pipe.py— full-run-safetytests/test_cli_export.py— impact, full-run-safetytests/test_cli_help.py— full-run-safetytests/test_cluster.py— full-run-safetytests/test_codebuddy.py— full-run-safetytests/test_community_hub_labels.py— full-run-safetytests/test_community_labels_skill.py— impact, full-run-safetytests/test_confidence.py— impact, full-run-safetytests/test_corrupt_graph_json.py— full-run-safetytests/test_cpp_nested_and_cli.py— impact, full-run-safetytests/test_cpp_objc_cross_file_calls.py— impact, full-run-safetytests/test_cpp_preprocess.py— full-run-safetytests/test_cross_extension_reexport_self_cycle.py— impact, full-run-safetytests/test_cross_language_call_resolution.py— impact, full-run-safetytests/test_cross_repo_external_call_guards.py— impact, full-run-safetytests/test_cross_repo_member_calls.py— impact, full-run-safetytests/test_cross_repo_shared_types.py— full-run-safetytests/test_csharp_call_site_generic_args.py— impact, full-run-safety- … and 241 more
non-code file(s) changed (
pyproject.toml,tests/fixtures/new_languages/sample.vb,uv.lock) → running the full suite for safety (a code graph can't see config/fixture/data deps)
changed code file(s) with no mapped test (
graphify/extractors/__init__.py,graphify/extractors/vbnet.py,pyproject.toml) — a coverage gap or a missing link — running the full suite rather than only the selected tests
Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.
· 2 grounded finding(s) anchored inline below; 84 more finding(s) on lines outside this diff (see the check run).
| }) | ||
|
|
||
|
|
||
| def extract_vbnet(path: Path) -> dict: |
There was a problem hiding this comment.
extract_vbnet()
fans out to 6 callees (efferent coupling).
Grounded coupling-delta finding (deterministic), not an LLM guess.
| add_edge(type_id, member_id, "contains", member) | ||
| return member_id | ||
|
|
||
| def process_type(block: Node, parent_id: str, namespace: str) -> None: |
There was a problem hiding this comment.
process_type()
fans out to 6 callees (efferent coupling).
Grounded coupling-delta finding (deterministic), not an LLM guess.
|
Shipped in v0.9.66 (on PyPI). Cherry-picked with authorship preserved so it shows under your GitHub contributions. Thanks @Abdul535! (New VB.NET extractor.) |
2 participants
What does this PR do?
Handles.vbdiscovery, case-insensitive calls, inheritance/interfaces, and partial-class call resolution.vbprojhandling and add the optional VB.NET parser extra with fixtures and malformed-input coverageType of change
How was this tested?
51 passedin the focused VB.NET and .NET suitegraphify update .completedGraphify-specific checklist