Forward Message Screen: Java/XML to Kotlin/Compose migration#163
Merged
Conversation
inthewaves
suggested changes
Jun 26, 2026
Comment on lines
+71
to
+77
| ConversationPickerScreen( | ||
| effectHandler = effectHandler, | ||
| onNavigateBack = ::finish, | ||
| allowMultiSelect = true, | ||
| isInitialDraftLoading = false, | ||
| initialDraft = draft, | ||
| ) |
Member
There was a problem hiding this comment.
The ConversationPickerScreen hardcodes strings such as share_intent_activity_label and share_recent_conversations_title; those parts should probably be customized / use custom strings for this forwarding path
e.g. at the bottom of the picker, it says "Enter a contact name or phone number to start a new message" which doesn't have the context of forwarding message. The title could be customized to indicate that we are forwarding messages
m4pl
force-pushed
the
forward-message-compose
branch
from
89c059c to
2bf6d90
Compare
m4pl
force-pushed
the
forward-message-compose
branch
from
2bf6d90 to
0c67a41
Compare
inthewaves
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated the Forward Message flow from Java + XML to Kotlin + Compose, reusing the shared
ConversationPickerScreento cut duplicated code.Screenshots