Add tests for conversation screen#125
Open
RankoR wants to merge 38 commits into
Open
Conversation
RankoR
force-pushed
the
task/conversation-compose-tests
branch
from
ccda3e6 to
72659cb
Compare
RankoR
force-pushed
the
task/conversation-compose-tests
branch
4 times, most recently
from
84902aa to
ab70f29
Compare
inthewaves
suggested changes
Jun 4, 2026
RankoR
force-pushed
the
task/conversation-compose-tests
branch
from
ab70f29 to
8bbe3b9
Compare
m4pl
reviewed
Jun 7, 2026
Comment on lines
+161
to
+173
| - name: Run instrumented tests and coverage gate | ||
| uses: reactivecircus/android-emulator-runner@e89f39f1abbbd05b1113a29cf4db69e7540cae5a | ||
| with: | ||
| api-level: 36 | ||
| arch: x86_64 | ||
| target: default | ||
| disable-animations: true | ||
| script: > | ||
| ./gradlew :app:connectedDebugAndroidTest :app:jacocoAndroidTestVerification | ||
| -PandroidTestCoverage=true | ||
| -PandroidTestMinCoverage=80 | ||
| -PandroidTestMinBranchCoverage=50 | ||
| --no-daemon --stacktrace --console=plain |
Contributor
There was a problem hiding this comment.
What do you think about caching the AVD snapshot? Could shave off the cold emulator boot each run
inthewaves
suggested changes
Jun 7, 2026
m4pl
reviewed
Jun 8, 2026
Contributor
There was a problem hiding this comment.
Nit: this test lives under messages/mapper, but the mapper under test is in ui/conversation/attachment/mapper. Moving it to the matching package/path would make ownership clearer
| } | ||
|
|
||
| @Test | ||
| fun commandMethods_doNothingWhenConversationIdIsBlankOrNull() { |
Contributor
There was a problem hiding this comment.
This test says the commands should do nothing for blank/null conversation ids, but it only checks effects and confirmation state
RankoR
force-pushed
the
task/conversation-compose-tests
branch
from
6090a5e to
1510d5b
Compare
RankoR
force-pushed
the
task/conversation-compose-tests
branch
from
82d6f1f to
d04b9cf
Compare
Member
|
This branch has conflicts that must be resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last (of 3) PR with Conversation screen rewritten with Kotlin and Compose.
Adds:
Coverage:
Doesn't change behavior of production code. All production code changes are: