Repository navigation
Keep overview zoom within the five-second budget on 2,000-item graphs #235
Description
Keep detail-to-overview zoom under the existing five-second budget for the actual 2,000-item/5,000-relationship graph. Actual post-dev acceptance for #231 failed after merging #232; this work is linked to the larger #193 path. Preserve readable content, exact relationship identity, selection/focus, camera, authored positions, no-write guards and cleanup. The five-second zoom and 45-second load limits must not be raised.
Done
- Verified actual dev
17acc25dc98978c64f87a5b0d6fb36b1833cdfa7, parents4b825b1+c098435, tree8e3b42d4960e2c69b24d2165f1f444ceeeaf0b01, identical to the reviewed source tree. - Audited post-dev CI 40812241527. Static, unit and runtime gates pass, but
large-symbolsfails: detail→overview scale0.1measured 5119.1ms, against<5000ms. First detail zoom was 3745.5ms; load was 27088ms. Test duration was 125186ms, so the 240s total deadline was not reached. - Preserved failed smoke artifact 12870958655, clean unchanged source fingerprint
34c6cda2542943a3e65e610b3c92dd9f94e0f837e7f418f42f3dcb8a617337b5. Only four strict reports ran; final snapshot/write/error guards were not reached. Pre-merge success is not post-dev acceptance. - Identified a concrete source hypothesis: below scale0.5,
clearCullexposes all source nodes;end.labelsthen callsupdateNodePresentationfor all 2,000 items andupdateEdgePositions(true)for all 5,000 relationships although overview CSS hides those groups.force=truebypasses dot-mode suppression. This control flow is verified; its share of the measured 5.119s is not yet demonstrated.
Next
- Create an isolated branch/worktree from actual dev17acc25; open an early draft PR and push clean chunks. Preserve the separately owned topology work in Organize graphs around their topology with readable card and wire clearances #233/Keep dense graph neighborhoods readable and organize connected items #234.
- Measure terminal presentation phases and work counts; implement bounded/coalesced hidden rendering without changing source simulation, authored layout, selection or graph identity.
- Refresh source cards/edges correctly on automatic overview exit and explicit Items mode, including held-pan reveal and priority changes. Add meaningful regression controls that fail if hidden rendering remains stale.
- Run small serial pure/component checks locally; run the exact 2k/5k journey and full required matrices on hosted CI, with zero retries and unchanged performance/data-integrity guards.
- Record measured before/after evidence canonically, obtain independent review, merge under repository rules and verify actual post-dev artifacts. Keep Make overview buses inspectable with endpoint highlighting #231 open until actual post-dev acceptance passes.
Running: No rerun of the failed source is in flight. The owner retains the local headed browser. No local 2k/full matrix is authorized for this correction.
Resume: Owner is the overview interaction reviewer, now authoring this follow-up; a separate reviewer will review the implementation. Start from dev17acc25, not the root topology worktree. Download failure with gh run download 40812241527 --repo GraphDone/GraphDone-Core --name smoke-results-17acc25dc98978c64f87a5b0d6fb36b1833cdfa7 --dir <owned-output>. Relevant entries are test-artifacts/ci-large-symbols/report.json, assets/large-symbols/9.json, 12.json and 15.zip (trace). Product source: InteractiveGraphVisualization.tsx, particularly culling, end.labels and updateEdgePositions; readiness measurement: tests/lib/graphZoomReady.ts. Do not relax readiness or discard failed evidence.
Activity
mvalancy commentedon Oct 29, 2026
Implementation checkpoint: branch
fix/overview-render-budget-20261029, draft PR #236, source968e95697514e005739a8d741239cf20dcf6e2d8from exact dev17acc25dc98978c64f87a5b0d6fb36b1833cdfa7.Done: coalesced terminal rendering after overview ownership commits; skip hidden culling/opacity/original-edge work; refresh current cards and edges before paint on automatic/manual Items return; cancel detached frames; retain camera/simulation/layout ownership. Existing 301 desktop/phone and 2k browser journeys gain work-count/real SVG assertions with unchanged guards and case counts. Canonical incident and local negative evidence are pushed.
Local serial validation: 16 focused tests passed in 4.86 s, web types passed, scoped lint zero errors. Deliberately restoring hidden work or removing Items refresh each fails two controls. No local browser or 2k fixture was run.
Next: independent exact-diff review; inspect new exact-head hosted CI and its 2k timing/full final guards. Do not rerun the failed dev unchanged or promote the earlier pre-merge success as current acceptance. Original actual-dev failed artifact remains linked above. #231 remains open.
Resume: checkout PR #236; list its CI via
gh run list --repo GraphDone/GraphDone-Core --branch fix/overview-render-budget-20261029. The earlieraa8ea81draft-doc run does not validate the implementation.mvalancy commentedon Oct 29, 2026
Hosted validation is running for final source
968e95697514e005739a8d741239cf20dcf6e2d8:The PR synthetic revision is
a6533a1b0461b386bcc9538317518d56900bdbf0, based on actual dev17acc25. Collect final logs withgh run view <run-id> --repo GraphDone/GraphDone-Core --log, list/download artifacts withgh run download <run-id> --repo GraphDone/GraphDone-Core. Done means completed conclusions plus audited source fingerprint, strict case results, real timing/visual attachments and runtime image provenance; a green summary alone is insufficient. No local browser is running for this correction. Non-author review is separately assigned.mvalancy commentedon Oct 29, 2026
Corrected in cc7bcb9: the Items return now publishes current routes and priority visibility before applying current zoom opacity. The existing desktop/phone journey also changes priority while overview is active, selects Items, and records/asserts real arrow transforms and full opacity before returning to the prior mode/priority. Added JSON and screenshot attachments are materialized before collection.
The author’s separate actual-helper D3/JSDOM control agrees with the independent reproduction: old order preserves opacity 0; route-first produces 1 at scale 1.2. Updated source passes all 16 focused tests (4.63 s), web types, and scoped lint (0 errors). No local browser was run. Fresh final-head CI is required; 968e956 is superseded for acceptance. Please recheck the narrow correction and full composed diff independently.
mvalancy commentedon Oct 29, 2026
Corrected source is
cc7bcb9e1fe4aff660004fcbe0472f14d6d744d2. Fresh CI 40815851023 and Comprehensive 40815851019 are running. API-confirmed synthetic revision18c558ab782622aa434ca13806b939132cfd674bhas parents[17acc25, cc7bcb9]; its treeb6bf17add278fb1f49f1bf837e868df81ff9525cequals the authored source tree. Non-author re-review is in progress.The obsolete 968e956 CI automatically canceled after the correction push. Its retained partial smoke artifact contains only three strict reports (schematic 6, smoke 6, item-wires 7, all passing), without a 2k report. It establishes no 2k timing improvement or final acceptance. Fresh full final-source evidence is still required.
mvalancy commentedon Oct 29, 2026
Checkpoint, 2026-10-29 04:38 UTC: source remains frozen and pushed at
cc7bcb9e1fe4aff660004fcbe0472f14d6d744d2; no local browser or large fixture has been started.Final CI 40815851023 has passed the 2k/5k headless step, 42-case new-user stage, inspector readability, and the desktop/phone Semantic LOD stage containing the new manual Items and arrow-paint assertions. Nested LOD is currently running; layout recovery, navigation/mobile and performance stages remain. The full strict archive is not uploaded yet, so exact zoom timings and actual PNG acceptance are still pending.
Comprehensive 40815851019 and all three final runtime images passed. Raw contracts/scans/logs were checked against the exact source-equal synthetic tree. The independent correction review verifies the arrow-order fix and static/runtime provenance; it explicitly awaits the complete browser artifact.
Next/resume: wait for CI completion, download
smoke-results-18c558ab782622aa434ca13806b939132cfd674bwithgh run download 40815851023 --repo GraphDone/GraphDone-Core --name smoke-results-18c558ab782622aa434ca13806b939132cfd674b, audit all 13 strict reports / 117 cases and expected 140 attachments, inspect 2k timing/work JSON and actual desktop/phone arrow PNGs, then obtain the non-author artifact review. Keep #231 open for actual post-integration acceptance. Do not infer the full result from completed steps or rerun unchanged source without a diagnosed reason.mvalancy commentedon Oct 29, 2026
Author final-artifact audit for
cc7bcb9e1fe4aff660004fcbe0472f14d6d744d2:CI 40815851023 and Comprehensive 40815851019 passed. The complete strict archive contains 13 reports, 117 passing cases, zero failed/warned/skipped cases, and 140 valid file-backed attachments. All strict reports ran from unchanged clean synthetic
18c558ab782622aa434ca13806b939132cfd674b, fingerprint9f724b0f59098e65ea4ca500470ddd2e96c0b33237de3648acbf45bc022cebc4; its exact parents are dev17acc25 + cc7bcb9 and treeb6bf17add278fb1f49f1bf837e868df81ff9525cequals source.The real 2,000-item / 5,000-relationship case completed in 193.913 s (324.592 s including fixture/setup/cleanup). Load was 24,291 ms against the unchanged 45-second guard. Browser zooms to detail / overview / detail took 4,244.3 / 4,137.2 / 3,802.3 ms, all below the unchanged five-second guard; corresponding call wall times were 5,550 / 5,576 / 5,080 ms. The overview transition retained item presentation passes 3 → 3 and the last rendered item scale 1.2; return to Items advanced the pass count to 4. Thus hidden terminal item rendering was actually skipped and current Items refreshed. Final full-data snapshot equality, held-pan reveal, exact original relationship access, and empty write/error receipts all passed.
The prior actual-dev overview failure was 5,119.1 ms. This corrected run is under budget, but cross-run timings are not a controlled benchmark; zero hidden work is the directly measured change. Actual post-integration acceptance is still required before closing #231.
Both 301-item desktop/phone journeys passed. Manual Items at scale 0.5 refreshed 65/35 current cards and 133/82 paths. Hidden priority → manual Items at scale 1.2 produced 18/12 routed arrows, each with computed opacity 1. I inspected both actual PNGs: arrows are painted. The four 2k overview geometry receipts show eight readable cards, no small text or recorded schematic clutter, and honest accounting of all 5,000 relationships. Dense local placement, offscreen endpoints and viewport/control clearance remain #233/#220 scope; these screenshots do not claim that broader work complete.
Full Node 22/24 suites, types, harness205, routing10 and real-Neo4j9 pass. All three final images have matching immutable IDs across build logs, scans and initial/replacement runtime contracts. API/generic scans have zero findings; the self-host image retains the documented 162 OS advisories with no fixed HIGH/CRITICAL. The independent reviewer has accepted the source correction and raw static/runtime provenance and is now independently auditing this complete browser archive. This comment is author evidence, not a substitute for that review.
Resume: download the archive above and inspect
test-artifacts/ci-large-symbols/report.jsonwith its threezoom-*-timing.jsonandtwo-thousand-node-performance.jsonattachments, plus bothmanual-items-priority-arrowsJSON/PNG attachments inci-semantic-lod/report.json. No local browser or heavy matrix was run for this correction.mvalancy commentedon Oct 29, 2026
Final independent source and artifact review is clear for exact
cc7bcb9e1fe4aff660004fcbe0472f14d6d744d2. The reviewer independently verified all 13 strict reports / 117 cases / 140 attachments, 73 JSON receipts, actual manual-arrow and 2k images, and final runtime provenance. The source finding is fully addressed and its thread resolved. PR #236 is now ready for integration.No merge or issue closure was performed by this author. Preserve #231 for actual post-dev validation, and require fresh composed evidence if another feature changes the tested tree. The original failed dev artifact and all superseded negative controls remain recorded; the owned branch is pushed and clean.
mvalancy commentedon Oct 29, 2026
PR #236 was integrated by the repository owner with the native exact-head admin operation into actual dev
479edf61a2e5f964de9034b6b7da26d2ffb4c11fat 2026-10-29 04:57:02 UTC. Independent API verification confirms exact parents[17acc25dc98978c64f87a5b0d6fb36b1833cdfa7, cc7bcb9e1fe4aff660004fcbe0472f14d6d744d2]and the reviewed source-equal treeb6bf17add278fb1f49f1bf837e868df81ff9525c.Actual post-dev CI 40820579099 and Comprehensive 40820579055 are running. Keep #235 and #231 open until this actual-revision evidence is accepted. The accepted pre-merge artifact is not being substituted for the post-dev run.
Resume: inspect those exact run IDs, collect logs via
gh api repos/GraphDone/GraphDone-Core/actions/jobs/<job-id>/logs, and download finalsmoke-results-479edf61a2e5f964de9034b6b7da26d2ffb4c11fwithgh run download 40820579099 --repo GraphDone/GraphDone-Core --name smoke-results-479edf61a2e5f964de9034b6b7da26d2ffb4c11f. Audit the same 13 strict reports / 117 cases, all attachments, 2k timings/work counters/final guards and actual arrow images, plus the new final-image contracts/scans. A separate non-author reviewer will check the final actual-revision artifacts. No local browser or heavy matrix is running for this follow-up.mvalancy commentedon Oct 29, 2026
Actual post-dev checkpoint for
479edf61a2e5f964de9034b6b7da26d2ffb4c11f: CI 40820579099 has passed the 2k/5k case, agent connection, inspector readability, new-user, desktop/phone Semantic LOD, nested LOD and durable layout recovery stages. Route compatibility is running; mobile and final performance stages remain. The complete strict archive is not uploaded yet, so exact actual-commit timing receipts and PNG review remain pending.Comprehensive 40820579055, types, package suites, harness/routing/Neo4j contracts and all three fresh runtime-image jobs passed. The author audited the actual merge parents/source-equal tree and new immutable image IDs across build logs, initial/replacement contracts and scans. API/generic have zero scan findings; self-host retains the same documented 162 OS advisories, with no fixed HIGH/CRITICAL. These are actual-merge artifacts, not reused pre-merge results.
Next: collect
smoke-results-479edf61a2e5f964de9034b6b7da26d2ffb4c11fwhen the job finishes, verify all 13 strict reports / 117 cases / 140 attachments, inspect actual 2k and manual-arrow receipts/PNGs, and obtain the separate non-author artifact check. #235 and #231 remain open for the repository owner to close after acceptance. No source changes or local browser/heavy tests were made during this validation.mvalancy commentedon Oct 29, 2026
Author audit of the actual post-dev revision
479edf61a2e5f964de9034b6b7da26d2ffb4c11f:CI 40820579099 and Comprehensive 40820579055 passed. The actual-merge strict archive contains 13 reports, 117 passing cases, zero failed/warned/skipped cases, and 140 valid attachments. Every strict report has the clean unchanged actual revision and fingerprint
677d8a2c88211ae2d1bf41ae359f8c4366c7eff5afa6e7bb8cbda871f88e5114. Merge parents and source-equal tree were independently checked against the reviewed source; these are fresh actual-merge artifacts.The real 2,000-item / 5,000-relationship case passed in 165.101 s (281.009 s including fixture/setup/cleanup). Load was 22,190 ms. Browser zooms to detail / overview / detail were 3,052.5 / 2,975.8 / 3,572.1 ms; corresponding call wall times were 4,197 / 4,042 / 4,990 ms. The unchanged load guard is 45 seconds and the browser zoom guard is five seconds. Actual work counters show overview retaining item passes 4 → 4 and last item scale 1.2, followed by Items refresh to pass 5. Final full-data snapshot equality, held-pan reveal, original relationship access, and empty write/error receipts all passed. These are measurements from this run, not a controlled cross-run benchmark.
Actual desktop/phone manual Items receipts contain 65/35 current compact cards and 133/82 paths. The hidden-priority/manual-return receipts contain 18/12 current arrows, all at opacity 1. I viewed the actual detail/overview and both arrow PNGs: restored arrows are painted, and overview shows eight readable summaries. The known detailed offscreen endpoints, crossings and viewport/control clearance remain separate #233/#220 work; this correction does not claim that broader placement path complete.
Actual Node 22/24 suites, types, harness205, routing10, real-Neo4j9 and installer checks pass. Fresh runtime image IDs match actual build logs, scans and initial/replacement contracts, with native SQLite and replacement recovery passing. API/generic scans have zero findings; the self-host image retains the documented 162 OS advisories with no fixed HIGH/CRITICAL. The direct living-graph suite also passed all three cases.
The separate non-author reviewer has been given this actual-revision archive, raw runtime/static evidence and PNGs for final confirmation. #235 and #231 remain open for the repository owner to close after that acceptance. No source edits, merge operation or issue closure were performed during this audit, and no local browser or heavy matrix was run.
mvalancy commentedon Oct 29, 2026
Independent actual post-dev acceptance is complete. Full evidence: #236 (comment) . Actual dev479edf61a2e5f964de9034b6b7da26d2ffb4c11f has the reviewed tree; CI40820579099 and Comprehensive40820579055 pass. The independently checked main archive has13 strict reports/117 passed cases/140 valid attachments and a clean unchanged actual-dev fingerprint.
The real2,000-item/5,000-edge graph loads in22,190ms and browser zooms take3,052.5/2,975.8/3,572.1ms under the original5,000ms guard. Overview terminal item passes stay4→4; return refreshes to5. Final exact snapshot, no-write and error guards pass. Actual desktop/phone arrow images show the corrected direction paint; raw manual-return, hidden-priority, held-pan, identity and runtime evidence is verified.
The original5,119.1ms failure is retained and superseded by successful actual integration, not a threshold relaxation. This issue can close under owner authority. #220/#233/#234 retain the separate layout/routing work. Reviewer did not close it.
mvalancy commentedon Oct 29, 2026
Resolved by PR #236, native exact-head administrative merge into
devat479edf61a2e5f964de9034b6b7da26d2ffb4c11f. Actual post-dev CI 40820579099 and Comprehensive 40820579055 pass, independently audited after merge.The actual archive contains13 strict reports/117 passing cases/140 valid attachments, no failed/warned/skipped cases; fresh packaged/runtime checks and exact parents/tree pass. Actual2k/5k load22.190s, browser zoom3.0525/2.9758/3.5721s under the unchanged5s gate (bridge wall4.197/4.042/4.990s); no view writes/errors, unchanged final snapshot, hidden terminal passes4→4, item return5. Real bus/arrow/pointer/keyboard evidence accepted. Independent final evidence.
Earlier actual-dev17acc25's5.119s failure remains recorded in #235. This closes the corrected overview rendering/interaction issue only; dense local Items/placement remains tracked separately in #233/PR #234 and arbitrary detailed wiring in #220.