Skip to content

Create the smaller image based on Alpine Linux 3.8#2

Open
okkyhtf wants to merge 2 commits into
GrahamDumpleton:masterfrom
okkyhtf:master
Open

Create the smaller image based on Alpine Linux 3.8#2
okkyhtf wants to merge 2 commits into
GrahamDumpleton:masterfrom
okkyhtf:master

Conversation

@okkyhtf

@okkyhtf okkyhtf commented Aug 30, 2018

Copy link
Copy Markdown

Hi, I found your software very handy for demo with my customers without any need for Internet (nip.io). But the final image size is very big (711 MB). I tried using Alpine Linux 3.8 instead as the base image and resulting to a smaller image (105 MB). I took the liberty to push my image (based on your repo) to https://hub.docker.com/r/okkyhtf/wildcard-dns-server/ for testing.

@GrahamDumpleton

Copy link
Copy Markdown
Owner

It is regarded as bad practice to run containers as root. Can you not run it is as root?

@GrahamDumpleton

Copy link
Copy Markdown
Owner

Also rather than replace existing Dockerfile, create it as Dockerfile.alpine so people have a choice.

@okkyhtf

okkyhtf commented Aug 31, 2018

Copy link
Copy Markdown
Author

I have reverted the original Dockerfile and move my Dockerfile to Dockerfile.alpine as you suggested. I also add a non-root user 1001 to run the server. Please have a look at this commit 9cd06cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants