Skip to content

feat: add image_pinned to skip registry rewrite for custom images #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeroasterisk wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

feat: add image_pinned to skip registry rewrite for custom images #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c33638
feat: add image_pinned to skip registry rewrite for custom images
zeroasterisk Jun 14, 2026
ef8c3e8
fix: address review comments — gofmt alignment + idiomatic Go
zeroasterisk Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/agent/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,11 @@ func (m *AgentManager) Start(ctx context.Context, opts api.StartOptions) (*api.A
// Apply image_registry rewrite to whatever image was resolved above.
// This rewrites the registry prefix for scion-* images. An explicit
// --image flag below takes full precedence (no rewrite).
if settings != nil && resolvedImage != "" {
// When image_pinned is set in the agent/template config, the image is
// used as-is without registry rewriting.
if finalScionCfg != nil && finalScionCfg.ImagePinned {
util.Debugf("image resolution: image_pinned=true, skipping registry rewrite")
} else if settings != nil && resolvedImage != "" {
imageRegistry := settings.ResolveImageRegistry(opts.Profile)
if imageRegistry != "" {
rewritten := config.RewriteImageRegistry(resolvedImage, imageRegistry)
Expand Down
1 change: 1 addition & 0 deletions pkg/api/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ type ScionConfig struct {
AuthSelectedType string `json:"auth_selectedType,omitempty" yaml:"auth_selectedType,omitempty"`
Resources *ResourceSpec `json:"resources,omitempty" yaml:"resources,omitempty"`
Image string `json:"image,omitempty" yaml:"image,omitempty"`
ImagePinned bool `json:"image_pinned,omitempty" yaml:"image_pinned,omitempty"`
Services []ServiceSpec `json:"services,omitempty" yaml:"services,omitempty"`
// MCPServers is the universal MCP server map. Keys are server names; values
// are the transport-agnostic config translated by each harness's
Expand Down