Skip to content

feat: add scion images build command#34

Open
fijimunkii wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
fijimunkii:feat/images-build-command
Open

feat: add scion images build command#34
fijimunkii wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
fijimunkii:feat/images-build-command

Conversation

@fijimunkii

@fijimunkii fijimunkii commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds scion images build command that wraps image-build/scripts/build-images.sh, so users can build container images directly from the CLI without needing to find and invoke the script manually
  • Supports all the same flags as the script: --registry (required), --target, --push, --platform, --tag, plus --source to specify the repo clone path when not running from within it
  • Exempts the images command group from grove and registry requirements in PersistentPreRunE — it's used to set up the registry before those things exist

Test plan

  • Unit tests added covering: command/flag registration, missing script error, correct arg passthrough with and without optional flags
  • Manually verified end-to-end: scion images build correctly invokes docker buildx with expected arguments
  • Pre-existing test failures in pkg/agent and pkg/runtimebroker confirmed unrelated to this change

Note: Depends on fix for build-images.sh empty platform array bug to work without --platform.

@google-cla

google-cla Bot commented Mar 30, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Wraps image-build/scripts/build-images.sh so users can build container
images directly from the CLI instead of finding and invoking the script
manually. Supports the same flags as the script (--registry, --target,
--push, --platform, --tag) plus --source to specify the repo clone path.

Exempts the images command group from grove and registry requirements in
PersistentPreRunE since it is used to set up the registry before any
grove or registry exists.
@fijimunkii fijimunkii force-pushed the feat/images-build-command branch from 47da235 to 04c50f2 Compare March 30, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant