feat: add scion images build command#34
Open
fijimunkii wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Wraps image-build/scripts/build-images.sh so users can build container images directly from the CLI instead of finding and invoking the script manually. Supports the same flags as the script (--registry, --target, --push, --platform, --tag) plus --source to specify the repo clone path. Exempts the images command group from grove and registry requirements in PersistentPreRunE since it is used to set up the registry before any grove or registry exists.
47da235 to
04c50f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scion images buildcommand that wrapsimage-build/scripts/build-images.sh, so users can build container images directly from the CLI without needing to find and invoke the script manually--registry(required),--target,--push,--platform,--tag, plus--sourceto specify the repo clone path when not running from within itimagescommand group from grove and registry requirements inPersistentPreRunE— it's used to set up the registry before those things existTest plan
scion images buildcorrectly invokes docker buildx with expected argumentspkg/agentandpkg/runtimebrokerconfirmed unrelated to this change