test: Parameterize filesystem GCS fixtures#1766
Draft
hashkanna wants to merge 1 commit into
Draft
Conversation
444ede5 to
5729a0f
Compare
ae58465 to
ad05705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Parameterize the filesystem system-test GCS fixture paths.
The filesystem data-source tests still default to
gs://pso-kokoro-resources/file_connection, so Kokoro can keep using the existing fixture bucket. Local and alternate validation environments can now point the same tests at a bucket by settingTEST_BUCKET, or fall back toPROJECT_IDwhen the project id matches the test bucket name.This keeps the test fixture layout unchanged while avoiding hard-coded access to the Kokoro bucket for local Ibis 7.1 validation.
Issues to be closed
N/A
Testing
venv/bin/python -m black --check tests/system/data_sources/test_filesystem.pyPROJECT_ID=<test-bucket-project> venv/bin/python -m pytest tests/system/data_sources/test_filesystem.py -qTZ=UTC venv/bin/python -m pytest tests/unit -qgit diff --check upstream/ibis-7.1-modernization...HEADChecklist
CONTRIBUTINGGuide.tests/local_check.shscript)