Skip to content

test: Parameterize filesystem GCS fixtures#1766

Draft
hashkanna wants to merge 1 commit into
GoogleCloudPlatform:ibis-7.1-modernizationfrom
hashkanna:kanna/ibis-7-1-modernization-gcs-fixtures
Draft

test: Parameterize filesystem GCS fixtures#1766
hashkanna wants to merge 1 commit into
GoogleCloudPlatform:ibis-7.1-modernizationfrom
hashkanna:kanna/ibis-7-1-modernization-gcs-fixtures

Conversation

@hashkanna

Copy link
Copy Markdown
Collaborator

Description of changes

Parameterize the filesystem system-test GCS fixture paths.

The filesystem data-source tests still default to gs://pso-kokoro-resources/file_connection, so Kokoro can keep using the existing fixture bucket. Local and alternate validation environments can now point the same tests at a bucket by setting TEST_BUCKET, or fall back to PROJECT_ID when the project id matches the test bucket name.

This keeps the test fixture layout unchanged while avoiding hard-coded access to the Kokoro bucket for local Ibis 7.1 validation.

Issues to be closed

N/A

Testing

  • venv/bin/python -m black --check tests/system/data_sources/test_filesystem.py
  • PROJECT_ID=<test-bucket-project> venv/bin/python -m pytest tests/system/data_sources/test_filesystem.py -q
  • TZ=UTC venv/bin/python -m pytest tests/unit -q
  • git diff --check upstream/ibis-7.1-modernization...HEAD

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@hashkanna hashkanna force-pushed the kanna/ibis-7-1-modernization-gcs-fixtures branch from ae58465 to ad05705 Compare June 22, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant