feat(job): Enable MTC for Pathways Workloads#5948
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Multi-Tier Checkpointing (MTC) in Pathways workloads within the HPC Toolkit. The changes include new CLI flags for enabling MTC, updates to the GKE orchestrator to handle MTC-specific volume mounts and sidecar configurations, and refinements to the JobSet templates to improve reliability and integration with GKE infrastructure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for Multi-Tier Checkpointing (MTC) in Pathways workloads by adding new CLI flags, updating documentation, and modifying the GKE job orchestrator to configure the required CSI driver, volumes, and sidecar shared memory. It also refactors the colocated Python sidecar into an init container and updates the JobSet restart strategy to BlockingRecreate. The feedback suggests avoiding hardcoding imagePullPolicy: Always on the sidecar container to prevent inefficient network pulls and reduce startup latency.
d75947d to
0d33853
Compare
5ed6d37
into
GoogleCloudPlatform:develop
This pull request introduces support for Multi-Tier Checkpointing (MTC) in Pathways workloads within the HPC Toolkit. The changes include new CLI flags for enabling MTC, updates to the GKE orchestrator to handle MTC-specific volume mounts and sidecar configurations, and refinements to the JobSet templates to improve reliability and integration with GKE infrastructure.