Merge v1.97.0 into Develop#5946
Conversation
Co-authored-by: Neelabh94 <neelgoyal@google.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request increments the project version to v1.97.0 and integrates a new community-contributed health monitoring agent for GKE GPU nodes. The changes include the full implementation of the monitoring tool, including its Go source code, deployment manifests, and necessary build scripts, alongside updates to the pre-commit configuration to maintain code standards for the new component. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new passive GPU health check tool (dcgm-healthcheck) for GKE clusters, running as a DaemonSet to monitor hardware, XID, and network errors, and patching Kubernetes Node objects accordingly. It includes the Go application, unit tests, a Dockerfile, deployment manifests, pre-commit hooks, and a build script. Additionally, the HPC Toolkit version is bumped from v1.96.0 to v1.97.0 across various Terraform modules and configuration files. Feedback on the Go code suggests improving the robustness of ConfigMap parsing for fatal XIDs by handling whitespace and newlines, and formatting the dmesg start time using RFC3339 to prevent timezone mismatch issues.
Merge v1.97.0 into Develop
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.