Skip to content

Merge v1.97.0 into Develop#5946

Merged
siddhartha-quad merged 5 commits into
developfrom
main
Jul 13, 2026
Merged

Merge v1.97.0 into Develop#5946
siddhartha-quad merged 5 commits into
developfrom
main

Conversation

@siddhartha-quad

Copy link
Copy Markdown
Contributor

Merge v1.97.0 into Develop

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@siddhartha-quad siddhartha-quad self-assigned this Jul 13, 2026
@siddhartha-quad
siddhartha-quad requested a review from a team as a code owner July 13, 2026 09:52
@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Jul 13, 2026
@github-actions github-actions Bot added the external PR from external contributor label Jul 13, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request increments the project version to v1.97.0 and integrates a new community-contributed health monitoring agent for GKE GPU nodes. The changes include the full implementation of the monitoring tool, including its Go source code, deployment manifests, and necessary build scripts, alongside updates to the pre-commit configuration to maintain code standards for the new component.

Highlights

  • Version Update: Updated the toolkit version to v1.97.0 across all Terraform modules and the internal configuration file.
  • New Feature: Introduced a new community tool, cluster-health-check, designed to monitor NVIDIA GPU health on GKE nodes and report issues via Kubernetes node conditions.
  • CI/CD Integration: Added new pre-commit hooks to perform linting, testing, and dependency validation for the newly added Go-based health check tool.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new passive GPU health check tool (dcgm-healthcheck) for GKE clusters, running as a DaemonSet to monitor hardware, XID, and network errors, and patching Kubernetes Node objects accordingly. It includes the Go application, unit tests, a Dockerfile, deployment manifests, pre-commit hooks, and a build script. Additionally, the HPC Toolkit version is bumped from v1.96.0 to v1.97.0 across various Terraform modules and configuration files. Feedback on the Go code suggests improving the robustness of ConfigMap parsing for fatal XIDs by handling whitespace and newlines, and formatting the dmesg start time using RFC3339 to prevent timezone mismatch issues.

Comment thread community/cluster-health-check/cmd/dcgm-healthcheck/main.go
Comment thread community/cluster-health-check/cmd/dcgm-healthcheck/main.go
@siddhartha-quad
siddhartha-quad merged commit e8d1af4 into develop Jul 13, 2026
21 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants