Skip to content

Merge v1.95.0 into Develop#5853

Closed
sudheer-quad wants to merge 6 commits into
developfrom
main
Closed

Merge v1.95.0 into Develop#5853
sudheer-quad wants to merge 6 commits into
developfrom
main

Conversation

@sudheer-quad

Copy link
Copy Markdown
Contributor

Merge v1.95.0 into Develop

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@github-actions github-actions Bot added the external PR from external contributor label Jun 25, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the HPC Toolkit to version v1.95.0. In addition to the version increment, it introduces functional improvements to GKE networking configurations, specifically adding subnetwork project support for HTCondor execute points and enabling Dataplane V2 for specific GKE examples. It also refines the default behavior and documentation for the Dynamic Resource Allocation (DRA) networking feature in GKE node pools.

Highlights

  • Version Bump: Updated the toolkit version from v1.94.0 to v1.95.0 across all module version files and the core configuration.
  • GKE Networking Enhancements: Added support for subnetwork_project in HTCondor execute points and enabled Dataplane V2 in the gke-a4x example.
  • GKE DRA Configuration: Updated the enable_dranet variable default to false and clarified its description in the gke-node-pool module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increments the toolkit version from v1.94.0 to v1.95.0 across multiple Terraform modules and Go configuration files. Additionally, it introduces the subnetwork_project parameter to the HTCondor execute point module, enables Dataplane V2 in the gke-a4x example, and updates the default value of enable_dranet from null to false in the GKE node pool module. There are no review comments, and I have no feedback to provide.

@sudheer-quad sudheer-quad self-assigned this Jun 25, 2026
@sudheer-quad sudheer-quad marked this pull request as ready for review June 25, 2026 16:35
@sudheer-quad sudheer-quad requested a review from a team as a code owner June 25, 2026 16:35
@sudheer-quad

Copy link
Copy Markdown
Contributor Author

/gcbrun

@sudheer-quad sudheer-quad marked this pull request as draft June 25, 2026 16:39
@sudheer-quad sudheer-quad marked this pull request as ready for review June 25, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants