Skip to content

Fix the warm up cache issue#5829

Open
LAVEEN wants to merge 6 commits into
GoogleCloudPlatform:developfrom
LAVEEN:develop
Open

Fix the warm up cache issue#5829
LAVEEN wants to merge 6 commits into
GoogleCloudPlatform:developfrom
LAVEEN:develop

Conversation

@LAVEEN

@LAVEEN LAVEEN commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

The integration test failure was caused by a cold cache miss during the FIO performance benchmark:

The test validates GCS Anywhere Cache (Rapid Cache), which is an SSD-backed zonal read cache.
Anywhere Cache is demand-driven and uses the admit-on-first-miss policy, meaning data is only loaded into the high-speed cache after it has been read for the first time.
The test file (/data/fio) is newly written during the test. Writing the file does not populate the read cache.
The benchmark ran a random-read test (--rw=randread) with small 4K blocks across the 1G file immediately after creation.
Because the cache was completely cold, nearly 100% of these random reads missed the cache and had to fetch data directly from GCS. This resulted in typical GCS direct-access latencies (~10ms per I/O), leading to only 129 IOPS (threshold: >= 300) and 516 KB/s bandwidth (threshold: >= 1000 KB/s).

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@LAVEEN LAVEEN self-assigned this Jun 22, 2026
@LAVEEN LAVEEN added the release-chore To not include into release notes label Jun 22, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a cache warm-up step to the FIO performance benchmark suite. By performing a sequential read of the test file before the actual latency test, the GCS Anywhere Cache is properly populated, preventing cache misses that previously caused the integration tests to fail due to high latency.

Highlights

  • Cache Warm-up Implementation: Added a pre-test fio read operation to populate the GCS Anywhere Cache, ensuring subsequent performance benchmarks run against a warm cache.
  • Test Stability: Addressed integration test failures caused by cold cache misses, ensuring performance metrics meet the required thresholds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a warmup step using fio before running the main read latency tests in both the Kubernetes job template (fio-test-job.yaml.j2) and the Ansible playbook (test-slurm-rapid-storage.yml). Feedback suggests adding set -e to the multi-line container script in the Kubernetes job template to ensure that any failure during the warmup step causes the script to exit immediately rather than silently proceeding to the latency test.

@LAVEEN LAVEEN marked this pull request as ready for review June 23, 2026 18:40
@LAVEEN LAVEEN requested a review from a team as a code owner June 23, 2026 18:40
@LAVEEN LAVEEN enabled auto-merge (squash) June 23, 2026 18:41
@LAVEEN LAVEEN removed their assignment Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants