Add managed lustre to a4h and a4x

[saara-tyagi27]

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the a4-highgpu-8g and a4x-highgpu-4g blueprints to utilize managed Lustre for shared storage instead of Filestore. It includes necessary configuration changes to the blueprints and updates the automated daily test scripts to handle these new dependencies while maintaining existing test coverage.

Highlights

• Managed Lustre Integration: Enabled managed Lustre as the default shared home directory for a4-highgpu-8g and a4x-highgpu-4g blueprints.
• Configuration Cleanup: Removed deprecated filestore configurations and associated IP range variables from the blueprints.
• Test Infrastructure Updates: Updated daily test build scripts to dynamically strip managed Lustre configurations, ensuring compatibility with current test environments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the a4-highgpu-8g and a4x-highgpu-4g Slurm blueprints to use Managed Lustre as the default shared filesystem instead of Filestore, and updates the daily integration tests to strip out these modules during test execution. Feedback on these changes highlights that the install_managed_lustre key in the a4x blueprint's JSON block is missing double quotes, and that obsolete comments instructing users on how to enable Managed Lustre should be cleaned up.

[gemini-code-assist]

The key install_managed_lustre is not double-quoted, which makes the JSON block in /var/tmp/slurm_vars.json syntactically invalid. Although some parsers (like YAML parsers) might tolerate unquoted keys, it is best practice to use valid JSON syntax for .json files to ensure compatibility and consistency with other keys in the same block.

            "install_managed_lustre": true,

[gemini-code-assist]

Since Managed Lustre is now enabled by default, the instructions in the comments above (lines 53-54) about uncommenting this section and the modules are now obsolete and should be removed or updated to avoid confusing users.

[gemini-code-assist]

Since Managed Lustre is now enabled by default, the instructions in the comments above (lines 51-52) about uncommenting this section and the modules are now obsolete and should be removed or updated to avoid confusing users.