Merge v1.90.0 into Develop

[sudheer-quad]

Merge v1.90.0 into Develop

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine version increment for the HPC Toolkit, updating the project version from v1.89.0 to v1.90.0. The changes primarily involve updating metadata tags within Terraform modules and adjusting version constants in the Go source code to ensure consistency across the repository.

Highlights

• Version Bump: Updated the toolkit version from v1.89.0 to v1.90.0 across all Terraform modules and internal configuration files.
• Metadata Updates: Updated provider_meta module_name strings in all Terraform modules to reflect the new v1.90.0 release.
• Tooling Updates: Updated the latestToolkitVersion constant in pkg/config/config.go and the help text in tools/cache_metadata/main.go to align with the new version.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Cluster Toolkit version from v1.89.0 to v1.90.0 across numerous Terraform modules and Go source files. The review feedback highlights two improvement opportunities: first, using a unique identifier for the internal Slurm login module's telemetry to avoid ambiguity with the public module; and second, replacing a hardcoded version string in the metadata tool with a centralized constant to improve maintainability and ensure a single source of truth.

[gemini-code-assist]

The module_name in provider_meta is set to schedmd-slurm-gcp-v6-login, which is identical to the name used by the public scheduler module. This duplication causes ambiguity in telemetry. Consider using a unique identifier like internal-slurm-gcp-login and ensure the version is updated to align with the current release process.

    module_name = "blueprints/terraform/hpc-toolkit:internal-slurm-gcp-login/v1.90.0"

References

1. The module version in the provider_meta block should be updated to align with the current release process, even if it differs from the corresponding public module's version.