Add Cursor Cloud specific instructions to AGENTS.md#979
Conversation
Co-authored-by: Dev Aggarwal <devxpy@gmail.com>
📝 WalkthroughWalkthroughThis PR adds a new "Cursor Cloud specific instructions" section to 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Line 79: Replace the contradictory sentence about `.venv` with a clear,
accurate statement: remove the claim that `pyenv local` creates a `.venv` file
and instead state that `.venv` in this repo is either a virtualenv directory or
a file containing the virtualenv name (per the Code Style section), and for
Cursor Cloud instructions specify which case applies—e.g., if Cloud uses a
virtualenv dir, tell users to invoke /workspace/.venv/bin/python, otherwise
instruct them to run `poetry run` or read the virtualenv name from the `.venv`
file; correct the reference to `pyenv local` to mention it creates
`.python-version` if that context is needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
|
||
| ### Gotchas | ||
|
|
||
| - The `.venv` file at repo root is created by `pyenv local` (contains `3.10.12`), not a virtualenv name as described in Code Style. In Cloud, use `/workspace/.venv/bin/python` directly or `poetry run`. |
There was a problem hiding this comment.
Critical: Contradictory .venv documentation.
This line contains a logical contradiction and conflicts with the Code Style section:
-
Internal contradiction: States
.venvfile is "created bypyenv local(contains3.10.12)" but then instructs to use/workspace/.venv/bin/python. If.venvwere a file containing3.10.12, the path/workspace/.venv/bin/pythoncannot exist. -
Conflicts with lines 13-16: The Code Style section documents that
.venvmay be a virtualenv directory OR a file containing the virtualenv name. This line introduces a third case (file containing Python version) that doesn't align with either. -
Technical accuracy:
pyenv local 3.10.12creates.python-version, not.venv.
Based on learnings, .venv semantics in this repo are: directory containing virtualenv OR file containing virtualenv name. This Cursor Cloud-specific note needs to clarify which case applies, or if Cloud uses a different setup entirely.
📝 Suggested clarification
-The `.venv` file at repo root is created by `pyenv local` (contains `3.10.12`), not a virtualenv name as described in Code Style. In Cloud, use `/workspace/.venv/bin/python` directly or `poetry run`.
+In Cursor Cloud, `.venv` is a virtualenv directory at `/workspace/.venv/` (not a file containing a virtualenv name as described in Code Style). Python 3.10.12 is set via `pyenv local`, which creates `.python-version`. Use `/workspace/.venv/bin/python` directly or `poetry run`.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@AGENTS.md` at line 79, Replace the contradictory sentence about `.venv` with
a clear, accurate statement: remove the claim that `pyenv local` creates a
`.venv` file and instead state that `.venv` in this repo is either a virtualenv
directory or a file containing the virtualenv name (per the Code Style section),
and for Cursor Cloud instructions specify which case applies—e.g., if Cloud uses
a virtualenv dir, tell users to invoke /workspace/.venv/bin/python, otherwise
instruct them to run `poetry run` or read the virtualenv name from the `.venv`
file; correct the reference to `pyenv local` to mention it creates
`.python-version` if that context is needed.
Adds a
## Cursor Cloud specific instructionssection toAGENTS.mdwith development environment documentation for future cloud agents:.venvsemantics, async test caveats)