Feat/gate keeper#1208
Open
pvishwa3 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds deployment configuration for the “gatekeeper” component to the GlueOps Platform chart by introducing a new container image value and an Argo CD Application to deploy both Gatekeeper CRD/RBAC manifests and the Gatekeeper service via the shared app Helm chart.
Changes:
- Add
container_images.app_gatekeeper.gatekeeper.image.*defaults tovalues.yamland document them inREADME.md. - Introduce
templates/application-gatekeeper.yamlArgo CDApplicationusing multi-source (Git manifests + Helm chart).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| values.yaml | Adds gatekeeper image configuration under container_images. |
| templates/application-gatekeeper.yaml | New Argo CD Application to deploy Gatekeeper CRD/RBAC plus the service via Helm. |
| README.md | Documents the new container_images.app_gatekeeper... values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+50
to
+55
| deployment: | ||
| {{- toYaml .Values.glueops_node_and_tolerations | nindent 12 }} | ||
| replicas: 1 | ||
| enabled: true | ||
| serviceAccountName: glueops-core-gatekeeper | ||
| env: |
| app_gatekeeper: | ||
| gatekeeper: | ||
| image: | ||
| registry: ghcr.io |
| sources: | ||
| # 1) CRD + RBAC pulled directly from the gatekeeper repo | ||
| - repoURL: https://github.com/GlueOps/platform-gatekeeper.git | ||
| targetRevision: HEAD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.