feat!: remove Slack notification surface entirely#142
Merged
Conversation
Removes the last remnants of Slack support, which was already deprecated and a no-op: - the enable_slack_notification_for_approval input definition (action.yml) - the deprecation-notice step that warned when it was set (action.yml) - the input's row in the README inputs table BREAKING CHANGE: the enable_slack_notification_for_approval input has been removed from the action's interface. In practice it was already ignored, and GitHub silently ignores undeclared 'with:' inputs, so existing workflows that still set it will continue to run. It is flagged as breaking because a documented input has been removed from the public API.
756a558 to
0d3d7b2
Compare
Contributor
|
⬇️ Download the full plan (tofu-plan.txt): https://github.com/GlueOps/github-actions-opentofu-continuous-delivery/actions/runs/28246478168/artifacts/7908891282 OpenTofu PlanShow plan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the last remnants of Slack support — which was already deprecated and a no-op:
enable_slack_notification_for_approvalinput definition (action.yml)action.yml)After this, there are zero
slackreferences in the repo (verified withgrep -rni slack).Breaking change
Flagged as breaking (
feat!:+BREAKING CHANGE:footer) because a documented input is removed from the action's public API → release-please will cut a major version (v6.0.0).In practice the runtime impact is minimal: the input was already ignored, and GitHub silently ignores undeclared
with:inputs, so existing workflows that still setenable_slack_notification_for_approvalwill continue to run (just without the deprecation warning). The major bump signals the API surface change to consumers.Release
On merge, release-please will open/refresh a release PR proposing v6.0.0.