Skip to content

fix: Add 'sso' preset to account-nuke script#73

Merged
venkatamutyala merged 1 commit into
mainfrom
venkatamutyala-patch-1
Oct 11, 2025
Merged

fix: Add 'sso' preset to account-nuke script#73
venkatamutyala merged 1 commit into
mainfrom
venkatamutyala-patch-1

Conversation

@venkatamutyala

@venkatamutyala venkatamutyala commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

User description

Added 'sso' preset to account-nuke script for resource management.


PR Type

Bug fix


Description

  • Add 'sso' preset to account-nuke script configuration

Diagram Walkthrough

flowchart LR
  config["Account-nuke config"] -- "add preset" --> sso["SSO preset"]
  sso --> resources["Protected SSO resources"]
Loading

File Walkthrough

Relevant files
Configuration changes
account-nuke.sh
Add SSO preset configuration                                                         

tools/aws/account-nuke.sh

  • Added 'sso' preset to the presets list under accounts configuration
+1/-0     

Added 'sso' preset to account-nuke script for resource management.
Copilot AI review requested due to automatic review settings October 11, 2025 21:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an 'sso' preset to the account-nuke script configuration to improve resource management during AWS account cleanup operations.

  • Added 'sso' preset to the AWS_ACCOUNT_ID_TO_DESTROY account configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codiumai-pr-agent-free

Copy link
Copy Markdown

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@github-actions github-actions Bot added the patch label Oct 11, 2025
@codiumai-pr-agent-free

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Define the missing 'sso' preset

Define the sso preset in the presets section, as it is currently used without a
definition, which will cause the aws-nuke tool to fail.

tools/aws/account-nuke.sh [40-42]

 presets:
   common:
     filters:
+  sso:
+    filters:
+      # Example: Exclude all SSO Admin Permission Sets and Instances.
+      # Adjust the filters based on the specific resources you need to preserve.
+      SSOAdminPermissionSet:
+        - type: glob
+          property: Name
+          value: "*"
+      SSOAdminInstance:
+        - type: glob
+          property: IdentityStoreId
+          value: "*"
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies that the sso preset is used but not defined, which would cause the aws-nuke tool to fail due to a configuration error.

High
  • More

@venkatamutyala venkatamutyala merged commit 45e5615 into main Oct 11, 2025
2 checks passed
@venkatamutyala venkatamutyala deleted the venkatamutyala-patch-1 branch October 11, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants